Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ci): Sort CI steps by length #4243

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Sep 30, 2022

Fail fast to save compute and time

@linear
Copy link

linear bot commented Sep 30, 2022

N8N-4835

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Sep 30, 2022
@ivov ivov requested a review from netroy September 30, 2022 10:39
@netroy netroy merged commit d47ff48 into master Oct 10, 2022
@netroy netroy deleted the n8n-4835-sort-ci-steps-by-length branch October 10, 2022 15:46
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Oct 10, 2022
@netroy
Copy link
Member

netroy commented Oct 10, 2022

@ivov looks like this broke the CI https://github.com/n8n-io/n8n/actions/runs/3220628348

ivov added a commit that referenced this pull request Oct 10, 2022
@ivov
Copy link
Contributor Author

ivov commented Oct 10, 2022

@typescript-eslint needs the deps of n8n-node-dev like n8n-core to be built first so that the values do not become any. So sadly build will need to come even before lint. Reverting: #4306

ivov added a commit that referenced this pull request Oct 10, 2022
⏪ Revert "perf(ci): Sort CI steps by length (#4243)"

This reverts commit d47ff48.
@janober
Copy link
Member

janober commented Oct 14, 2022

Got released with n8n@0.198.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Oct 14, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
* ⚡ Sort CI steps by length

* 🐛 `Build` before `test` for n8n packages
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
⏪ Revert "perf(ci): Sort CI steps by length (n8n-io#4243)"

This reverts commit d47ff48.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants