Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(ci): Sort CI steps by length #4243

Merged
merged 2 commits into from
Oct 10, 2022
Merged

perf(ci): Sort CI steps by length #4243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
502465c
:zap: Sort CI steps by length
ivov Sep 30, 2022
15e5410
:bug: `Build` before `test` for n8n packages
ivov Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci-master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ jobs:
- name: Install npm and dependencies
run: npm install -g npm@latest && npm install

- name: Lint
run: npm run lint

- name: Build
run: npm run build --if-present

- name: Test
run: npm run test

- name: Lint
run: npm run lint
netroy marked this conversation as resolved.
Show resolved Hide resolved
12 changes: 6 additions & 6 deletions .github/workflows/ci-pull-requests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,16 @@ jobs:
- name: Install npm and dependencies
run: npm install -g npm@latest && npm install

- name: Build
run: npm run build --if-present

- name: Test
run: npm run test

- name: Fetch base branch for `git diff`
run: git fetch origin ${{ github.event.pull_request.base.ref }}:${{ github.event.pull_request.base.ref }}

- name: Run ESLint on changes only
env:
ESLINT_PLUGIN_DIFF_COMMIT: ${{ github.event.pull_request.base.ref }}
run: npm run lint

- name: Build
run: npm run build --if-present

- name: Test
run: npm run test