Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add license support to n8n #4566

Merged
merged 30 commits into from
Nov 21, 2022
Merged

feat(core): Add license support to n8n #4566

merged 30 commits into from
Nov 21, 2022

Conversation

mutdmour
Copy link
Contributor

@mutdmour mutdmour commented Nov 9, 2022

No description provided.

@linear
Copy link

linear bot commented Nov 9, 2022

N8N-5283

@mutdmour mutdmour marked this pull request as ready for review November 9, 2022 21:11
@mutdmour mutdmour changed the title feat(cli): add license support to n8n feat(cli): Add license support to n8n Nov 9, 2022
@mutdmour mutdmour changed the title feat(cli): Add license support to n8n feat(core): Add license support to n8n Nov 9, 2022
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 9, 2022
csuermann
csuermann previously approved these changes Nov 10, 2022
Copy link
Contributor

@csuermann csuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this coming to life! 🙌

Please consider the changes I proposed.

packages/cli/src/License.ts Show resolved Hide resolved
packages/cli/src/config/schema.ts Outdated Show resolved Hide resolved
packages/cli/src/constants.ts Outdated Show resolved Hide resolved
Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
csuermann
csuermann previously approved these changes Nov 21, 2022
Copy link
Contributor

@csuermann csuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor suggestions.

packages/cli/package.json Outdated Show resolved Hide resolved
return this.manager.hasFeatureEnabled(feature);
}

isSharingEnabled() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding the cloud-specific checks here? That way we could concentrate these special checks here and not have them scattered across the codebase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which checks do you mean.. the cloud check we need is already here.. checking for config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait I get it.. you want to move config checks here.. not sure it makes sense.. I would have a separate module that manages features..

packages/cli/src/config/schema.ts Outdated Show resolved Hide resolved
packages/cli/src/constants.ts Show resolved Hide resolved
Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
@mutdmour mutdmour merged commit 30e5d3d into master Nov 21, 2022
@mutdmour mutdmour deleted the N8N-5283-license-sdk branch November 21, 2022 14:41
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 21, 2022
MiloradFilipovic added a commit that referenced this pull request Nov 21, 2022
* feature/ad-ldap: (108 commits)
  👕 Fix linting problem
  fix: Workflow activation should not crash if one of the credential is invalid (#4671)
  feat(core): Add license support to n8n (#4566)
  fix: Use the updated slots syntax in ResourceLocator (no-changelog) (#4663)
  fix: Community package uninstall button should show the confirmation modal (no-changelog) (#4668)
  fix: Fix broken n8n-info-tip slots (#4665)
  fix(editor): Table view column limit tooltip (#4655)
  ci: Block execution of `npm install` (no-changelog) (#4662)
  fix(editor): Prevent node-creator tabs from showing when toggled by CanvasAddButton (#4661)
  fix(Schedule Trigger Node): Fixes inconsitent behavior with cron and weekly intervals (#4558)
  fix(core): Fix for unused imports
  fix: Add temporary slot syntax lint exceptions (no-changelog) (#4652)
  fix(editor): Fix missing resource locator component (#4649)
  refactor(core): Introduce overload for record-type node parameter (no-changelog) (#4648)
  refactor(core): Introduce overload for number-type node parameter (no-changelog) (#4644)
  refactor: Migrate Vue slots to the new syntax (#4603)
  refactor(core): Introduce overload for boolean-type node parameter (no-changelog) (#4647)
  fix: Make users fakedoor route visible on cloud (#4645)
  📚 Update CHANGELOG.md and main package.json to 0.203.1
  🔖 Release n8n@0.203.1
  ...

# Conflicts:
#	packages/design-system/src/components/N8nFormInput/FormInput.vue
#	packages/design-system/src/components/N8nFormInputs/FormInputs.stories.js
#	packages/design-system/src/components/N8nFormInputs/FormInputs.vue
#	packages/design-system/src/types/form.ts
@janober
Copy link
Member

janober commented Dec 7, 2022

Got released with n8n@0.206.1

@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants