refactor(core): Introduce overload for record-type node parameter (no-changelog) #4648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
ivov
commented
Nov 18, 2022
| itemIndex: number, | ||
| fallbackValue?: IDataObject, | ||
| options?: IGetNodeParameterOptions, | ||
| ): IDataObject; |
There was a problem hiding this comment.
Ideally we should narrow down IDataObject in future, but too widely used to refactor in this PR.
There was a problem hiding this comment.
I'm certain any PR wanting to replace IDataObject with stronger types is going to me much larger than this PR 😮💨 🤦🏽
n8n-assistant
bot
added
the
Upcoming Release
MiloradFilipovic
added a commit
that referenced
this pull request
Nov 18, 2022
* master: fix(editor): Fix missing resource locator component (#4649) refactor(core): Introduce overload for record-type node parameter (no-changelog) (#4648) refactor(core): Introduce overload for number-type node parameter (no-changelog) (#4644) refactor: Migrate Vue slots to the new syntax (#4603) refactor(core): Introduce overload for boolean-type node parameter (no-changelog) (#4647) fix: Make users fakedoor route visible on cloud (#4645) 📚 Update CHANGELOG.md and main package.json to 0.203.1
MiloradFilipovic
added a commit
that referenced
this pull request
Nov 21, 2022
* feature/ad-ldap: (108 commits) 👕 Fix linting problem fix: Workflow activation should not crash if one of the credential is invalid (#4671) feat(core): Add license support to n8n (#4566) fix: Use the updated slots syntax in ResourceLocator (no-changelog) (#4663) fix: Community package uninstall button should show the confirmation modal (no-changelog) (#4668) fix: Fix broken n8n-info-tip slots (#4665) fix(editor): Table view column limit tooltip (#4655) ci: Block execution of `npm install` (no-changelog) (#4662) fix(editor): Prevent node-creator tabs from showing when toggled by CanvasAddButton (#4661) fix(Schedule Trigger Node): Fixes inconsitent behavior with cron and weekly intervals (#4558) fix(core): Fix for unused imports fix: Add temporary slot syntax lint exceptions (no-changelog) (#4652) fix(editor): Fix missing resource locator component (#4649) refactor(core): Introduce overload for record-type node parameter (no-changelog) (#4648) refactor(core): Introduce overload for number-type node parameter (no-changelog) (#4644) refactor: Migrate Vue slots to the new syntax (#4603) refactor(core): Introduce overload for boolean-type node parameter (no-changelog) (#4647) fix: Make users fakedoor route visible on cloud (#4645) 📚 Update CHANGELOG.md and main package.json to 0.203.1 🔖 Release n8n@0.203.1 ... # Conflicts: # packages/design-system/src/components/N8nFormInput/FormInput.vue # packages/design-system/src/components/N8nFormInputs/FormInputs.stories.js # packages/design-system/src/components/N8nFormInputs/FormInputs.vue # packages/design-system/src/types/form.ts
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.