refactor(editor): Upgrade to jsPlumb 5 #4989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…migrate-to-jsplumb-5
n8n-assistant
bot
added
core
netroy
previously requested changes
Dec 22, 2022
# Conflicts: # packages/editor-ui/src/Interface.ts # packages/editor-ui/src/views/NodeView.vue # pnpm-lock.yaml
mutdmour
reviewed
Jan 24, 2023
mutdmour
reviewed
Jan 24, 2023
| }); | ||
| this.instance.bind(EVENT_CONNECTION_MOUSEOVER, (connection: Connection) => { | ||
| try { | ||
| if (this.exitTimer !== undefined) { |
There was a problem hiding this comment.
the timers worked better when they were not global, but tied to connection state.. for example if you put two connections next to each other and hover quickly between them, it's easy to get stuck in a hover state without actions.. not the biggest issue..
…er (#5271) * 🔨 Handling router errors in main sidebar, removing unused code * 🔨 Handling router errors in modals
* ci(core): Copy patches dir to Docker (no-changelog) * Update patch * Update package-lock * reapply the patch * skip patchedDependencies after the frontend is built --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
mutdmour
previously approved these changes
Jan 30, 2023
mutdmour
approved these changes
Jan 30, 2023
n8n-assistant
bot
added
the
Upcoming Release
MiloradFilipovic
added a commit
that referenced
this pull request
Jan 31, 2023
* master: refactor(core): Luxon dependency update (#5301) feat(Notion Node): Add image block (#5237) fix(Set Node): Fix behaviour when selecting continueOnFail & PairedItem (#5257) feat(editor): Continue to show mapping tooltip after dismiss (#5289) refactor(editor): Upgrade to jsPlumb 5 (#4989) feat(core): Export OpenAPI spec for external tools (#5294) refactor: Clean up workflow stats test file (#5282) docs(Postgres Node): Remove overkill notice for postgres & paireditem (#5291) fix(n8n Trigger Node): Use the new icon for N8N Trigger node (no-changelog) (#5290) fix(editor): Add SMTP info translation link slot (#5288) refactor(core): Load and validate all config at startup (no-changelog) (#5283) feat: Add multiple workflows text search filtering E2E test scenarios (no-changelog) (#5276) ci: Re-enable CI jobs on nodejs 14.x (no-changelog) (#5153) ci(editor): Update RunDataSchema test (no-changelog) (#5287) feat(editor): Add mapping support for data paths (#5191) test: Add unit testing to nodes (no-changelog) (#4890) ci(core): Fix docker nightly/custom image build (no-changelog) (#5284)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.