fix(editor): Handling router errors when navigation is canceled by user #5271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
ivov
approved these changes
Jan 27, 2023
| @@ -155,6 +155,7 @@ import { useWorkflowsEEStore } from '@/stores/workflows.ee'; | |||
| import { ITelemetryTrackProperties } from 'n8n-workflow'; | |||
| import { useUsageStore } from '@/stores/usage'; | |||
| import { BaseTextKey } from '@/plugins/i18n'; | |||
| import { isNavigationFailure } from 'vue-router'; | |||
There was a problem hiding this comment.
For learning, we cannot set it up like in the docs?
There was a problem hiding this comment.
From what I've been able to test out, this hook is not triggered if navigation is canceled from another guard (such as beforeRouteLeave).
| if (this.$router.currentRoute.name !== VIEWS.NEW_WORKFLOW) { | ||
| this.workflowsStore.setWorkflowId(PLACEHOLDER_EMPTY_WORKFLOW_ID); | ||
| this.$router.push({ name: VIEWS.NEW_WORKFLOW }); | ||
| goToRoute(route: string | { name: string }) { |
There was a problem hiding this comment.
createNewWorkflow was an unused leftover?
There was a problem hiding this comment.
Yep, that's when we had New workflow menu item in the sidebar (before the Workflows page).
OlegIvaniv
pushed a commit
that referenced
this pull request
Jan 30, 2023
…er (#5271) * 🔨 Handling router errors in main sidebar, removing unused code * 🔨 Handling router errors in modals
OlegIvaniv
added a commit
that referenced
this pull request
Jan 30, 2023
* WIP: Nodeview * Replace types * Finish N8nPlus endpoint type * Working on connector * Apply prettier * Fixed prettier issues * Debugging rendering * Fixed connectorrs position recalc * Fix snapping and output labels, WIP dragging * Fix N8nPlus endpoint rendering issues * Cleanup * Fix undo/redo and canvas add button position, cleanup * Cleanup * Revert accidental CLI changes * Fix pnpm-lock * Address bugs that came up during review * Reset CLI package from master * Various fixes * Fix run items label toggling * Linter fixes * Fix stalk size for larger run items label * Remove comment * Correctly reset workspace after renaming the node * Fix canvas e2e tests * Fix undo/redo tests * Fix stalk positioning and triggering of endpoint overlays * Repaint connections on pin removal * Limit repaintings * Unbind jsPlumb events on deactivation * Fix jsPlumb managment of Sticky and minor memort managment improvments * Address rest of PR points * Lint fix * Copy patches folder to docker * Fix e2e tests * set allowNonAppliedPatches to allow build * fix(editor): Handling router errors when navigation is canceled by user (#5271) * 🔨 Handling router errors in main sidebar, removing unused code * 🔨 Handling router errors in modals * ci(core): Fix docker nightly/custom image build (no-changelog) (#5284) * ci(core): Copy patches dir to Docker (no-changelog) * Update patch * Update package-lock * reapply the patch * skip patchedDependencies after the frontend is built --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in> * Fix connector hover state on success * Remove allowNonAppliedPatches from package.json --------- Co-authored-by: Milorad FIlipović <milorad@n8n.io> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):