Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HubSpot Node): Fix issue with contact lists not working #5582

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Feb 28, 2023

Github issue / Community forum post (link here to close automatically):

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Feb 28, 2023
@netroy netroy changed the title fix(Hubspot Node): Fix missing scope on Hubspot OAuth credential fix(HubSpot Node): Fix missing scope on Hubspot OAuth credential Feb 28, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@Joffcom Joffcom changed the title fix(HubSpot Node): Fix missing scope on Hubspot OAuth credential fix(HubSpot Node): Fix issue with contact lists not working Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (915cfa0) 31.99% compared to head (ac150c5) 31.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5582      +/-   ##
==========================================
- Coverage   31.99%   31.99%   -0.01%     
==========================================
  Files        3277     3277              
  Lines      197969   197969              
  Branches    21595    21589       -6     
==========================================
- Hits        63350    63341       -9     
- Misses     133558   133567       +9     
  Partials     1061     1061              
Files Changed Coverage Δ
...s-base/credentials/HubspotOAuth2Api.credentials.ts 0.00% <ø> (ø)
...es-base/nodes/Hubspot/V2/ContactListDescription.ts 0.00% <ø> (ø)
...ages/nodes-base/nodes/Hubspot/V2/HubspotV2.node.ts 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Sep 12, 2023

Passing run #2151 ↗︎

0 238 0 0 Flakiness 0

Details:

🌳 node-339 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project: n8n Commit: ac150c5784
Status: Passed Duration: 08:00 💡
Started: Sep 12, 2023 3:54 PM Ended: Sep 12, 2023 4:02 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit 6e5a4f6 into master Sep 12, 2023
54 checks passed
@Joffcom Joffcom deleted the node-339 branch September 12, 2023 16:04
@github-actions github-actions bot mentioned this pull request Sep 13, 2023
netroy added a commit that referenced this pull request Sep 13, 2023
# [1.7.0](https://github.com/n8n-io/n8n/compare/n8n@1.6.0...n8n@1.7.0)
(2023-09-13)


### Bug Fixes

* **Code Node:** Disable WASM to address CVE-2023-37903
([#7122](#7122))
([36a8e91](36a8e91))
* **Code Node:** Upgrade vm2 to address CVE-2023-37466
([#7123](#7123))
([0a35025](0a35025))
* **core:** Disable Node.js custom inspection to address CVE-2023-37903
([#7125](#7125))
([a223734](a223734)),
closes [#7122](#7122)
* **editor** Account for nanoid workflow ids for subworkflow execute
policy ([#7094](#7094))
([67092c0](67092c0))
* **editor:** Unbind workflow endpoint events in case of workspace reset
([#7129](#7129))
([c9b7948](c9b7948))
* **editor:** Update git repo url validation regex
([#7151](#7151))
([e51f173](e51f173))
* **Google Cloud Firestore Node:** Fix empty string interpreted as
number ([#7136](#7136))
([915cfa0](915cfa0))
* **HubSpot Node:** Fix issue with contact lists not working
([#5582](#5582))
([6e5a4f6](6e5a4f6))
* **Postgres Node:** Fix automatic column mapping
([#7121](#7121))
([92af131](92af131))
* **Zoho CRM Node:** Fix issue with Sales Order not updating
([#6959](#6959))
([fd800b6](fd800b6))


### Features

* **core:** Add an option to enable WAL mode for SQLite
([#7118](#7118))
([1d1a022](1d1a022))
* **core:** Add commands to workers to respond with current state
([#7029](#7029))
([7b49cf2](7b49cf2))
* **Salesforce Node:** Add fax field to lead option
([#7030](#7030))
([01f875a](01f875a))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Sep 13, 2023
netroy added a commit that referenced this pull request Sep 13, 2023
# [1.7.0](https://github.com/n8n-io/n8n/compare/n8n@1.6.0...n8n@1.7.0)
(2023-09-13)


### Bug Fixes

* **Code Node:** Disable WASM to address CVE-2023-37903
([#7122](#7122))
([36a8e91](36a8e91))
* **Code Node:** Upgrade vm2 to address CVE-2023-37466
([#7123](#7123))
([0a35025](0a35025))
* **core:** Disable Node.js custom inspection to address CVE-2023-37903
([#7125](#7125))
([a223734](a223734))
* **editor** Account for nanoid workflow ids for subworkflow execute
policy ([#7094](#7094))
([67092c0](67092c0))
* **editor:** Tweak hover area of workflow / cred cards
([#7108](#7108))
([217de21](217de21))
* **editor:** Unbind workflow endpoint events in case of workspace reset
([#7129](#7129))
([c9b7948](c9b7948))
* **editor:** Update git repo url validation regex
([#7151](#7151))
([e51f173](e51f173))
* **Google Cloud Firestore Node:** Fix empty string interpreted as
number ([#7136](#7136))
([915cfa0](915cfa0))
* **HubSpot Node:** Fix issue with contact lists not working
([#5582](#5582))
([6e5a4f6](6e5a4f6))
* **Postgres Node:** Fix automatic column mapping
([#7121](#7121))
([92af131](92af131))
* **Zoho CRM Node:** Fix issue with Sales Order not updating
([#6959](#6959))
([fd800b6](fd800b6))


### Features

* **core:** Add an option to enable WAL mode for SQLite
([#7118](#7118))
([1d1a022](1d1a022))
* **core:** Add commands to workers to respond with current state
([#7029](#7029))
([7b49cf2](7b49cf2))
* **Salesforce Node:** Add fax field to lead option
([#7030](#7030))
([01f875a](01f875a))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Sep 14, 2023

Got released with n8n@1.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants