feat(core): Add commands to workers to respond with current state #7029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-with-current-state # Conflicts: # packages/cli/src/commands/worker.ts
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
core
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7029 +/- ##
==========================================
+ Coverage 31.90% 31.94% +0.04%
==========================================
Files 3268 3271 +3
Lines 197657 197796 +139
Branches 21528 21551 +23
==========================================
+ Hits 63058 63195 +137
+ Misses 133561 133558 -3
- Partials 1038 1043 +5
☔ View full report in Codecov by Sentry. |
krynble
reviewed
Aug 30, 2023
…-with-current-state # Conflicts: # packages/cli/src/AbstractServer.ts
…-with-current-state # Conflicts: # packages/cli/src/eventbus/eventBus.controller.ts
…-with-current-state
krynble
approved these changes
Sep 7, 2023
1 flaky test on run #2133 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Data mapping > shows you can drop to inputs, including booleans |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
✅ All Cypress E2E specs passed |
flipswitchingmonkey
deleted the
pay-754-add-commands-to-workers-to-respond-with-current-state
branch
Merged
netroy
added a commit
that referenced
this pull request
Sep 13, 2023
# [1.7.0](https://github.com/n8n-io/n8n/compare/n8n@1.6.0...n8n@1.7.0) (2023-09-13) ### Bug Fixes * **Code Node:** Disable WASM to address CVE-2023-37903 ([#7122](#7122)) ([36a8e91](36a8e91)) * **Code Node:** Upgrade vm2 to address CVE-2023-37466 ([#7123](#7123)) ([0a35025](0a35025)) * **core:** Disable Node.js custom inspection to address CVE-2023-37903 ([#7125](#7125)) ([a223734](a223734)), closes [#7122](#7122) * **editor** Account for nanoid workflow ids for subworkflow execute policy ([#7094](#7094)) ([67092c0](67092c0)) * **editor:** Unbind workflow endpoint events in case of workspace reset ([#7129](#7129)) ([c9b7948](c9b7948)) * **editor:** Update git repo url validation regex ([#7151](#7151)) ([e51f173](e51f173)) * **Google Cloud Firestore Node:** Fix empty string interpreted as number ([#7136](#7136)) ([915cfa0](915cfa0)) * **HubSpot Node:** Fix issue with contact lists not working ([#5582](#5582)) ([6e5a4f6](6e5a4f6)) * **Postgres Node:** Fix automatic column mapping ([#7121](#7121)) ([92af131](92af131)) * **Zoho CRM Node:** Fix issue with Sales Order not updating ([#6959](#6959)) ([fd800b6](fd800b6)) ### Features * **core:** Add an option to enable WAL mode for SQLite ([#7118](#7118)) ([1d1a022](1d1a022)) * **core:** Add commands to workers to respond with current state ([#7029](#7029)) ([7b49cf2](7b49cf2)) * **Salesforce Node:** Add fax field to lead option ([#7030](#7030)) ([01f875a](01f875a)) Co-authored-by: netroy <netroy@users.noreply.github.com>
Merged
netroy
added a commit
that referenced
this pull request
Sep 13, 2023
# [1.7.0](https://github.com/n8n-io/n8n/compare/n8n@1.6.0...n8n@1.7.0) (2023-09-13) ### Bug Fixes * **Code Node:** Disable WASM to address CVE-2023-37903 ([#7122](#7122)) ([36a8e91](36a8e91)) * **Code Node:** Upgrade vm2 to address CVE-2023-37466 ([#7123](#7123)) ([0a35025](0a35025)) * **core:** Disable Node.js custom inspection to address CVE-2023-37903 ([#7125](#7125)) ([a223734](a223734)) * **editor** Account for nanoid workflow ids for subworkflow execute policy ([#7094](#7094)) ([67092c0](67092c0)) * **editor:** Tweak hover area of workflow / cred cards ([#7108](#7108)) ([217de21](217de21)) * **editor:** Unbind workflow endpoint events in case of workspace reset ([#7129](#7129)) ([c9b7948](c9b7948)) * **editor:** Update git repo url validation regex ([#7151](#7151)) ([e51f173](e51f173)) * **Google Cloud Firestore Node:** Fix empty string interpreted as number ([#7136](#7136)) ([915cfa0](915cfa0)) * **HubSpot Node:** Fix issue with contact lists not working ([#5582](#5582)) ([6e5a4f6](6e5a4f6)) * **Postgres Node:** Fix automatic column mapping ([#7121](#7121)) ([92af131](92af131)) * **Zoho CRM Node:** Fix issue with Sales Order not updating ([#6959](#6959)) ([fd800b6](fd800b6)) ### Features * **core:** Add an option to enable WAL mode for SQLite ([#7118](#7118)) ([1d1a022](1d1a022)) * **core:** Add commands to workers to respond with current state ([#7029](#7029)) ([7b49cf2](7b49cf2)) * **Salesforce Node:** Add fax field to lead option ([#7030](#7030)) ([01f875a](01f875a)) Co-authored-by: netroy <netroy@users.noreply.github.com>
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new endpoints to the REST API:
/orchestration/worker/statusand/orchestration/worker/idCurrently these just trigger the return of status / ids from the workers via the redis back channel, this still needs to be handled and passed through to the frontend.
It also adds the eventbus to each worker, and triggers a reload of those eventbus instances when the configuration changes on the main instances.