ci: Set up Turborepo cache again (no-changelog) #7805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
reviewed
Nov 24, 2023
netroy
reviewed
Nov 24, 2023
Comment on lines
+11
to
+14
| "build:backend": {}, | ||
| "build:frontend": {}, | ||
| "test:backend": {}, | ||
| "test:frontend": {}, |
There was a problem hiding this comment.
I don't think this alone is enough. we need to define what workspaces to run the build command in. We could try updating https://github.com/n8n-io/n8n/blob/master/package.json#L28 to use turbo run --filter= instead of pnpm --filter=, but unlike pnpm, turbo will still run the tests for editor, because n8n depends on that package.
|
This PR was lost in the shuffle. Closing for now, let's revisit when we have time for this. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up this GH action so we can use the GH runner's cache service for Turborepo runs.
The last time we had to revert but the full logs of the issue are no longer available so we might have to end up triggering the same issue again for debugging.