Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Set up Turborepo cache again (no-changelog) #7805

Closed
wants to merge 3 commits into from
Closed

ci: Set up Turborepo cache again (no-changelog) #7805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcb5ea6
ci: Set up Turborepo cache again (no-changelog)
ivov Nov 24, 2023
885971a
Configure Turbo cache for unit tests as well
ivov Nov 24, 2023
af9d802
Add new pipelines to Turbo manifest
ivov Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci-master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ jobs:
- name: Install dependencies
run: pnpm install --frozen-lockfile

- name: Configure Turbo cache
uses: dtinth/setup-github-actions-caching-for-turbo@v1

- name: Build
run: pnpm build

Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ci-postgres-mysql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ jobs:
cache: 'pnpm'
- run: pnpm install --frozen-lockfile

- name: Configure Turbo cache
uses: dtinth/setup-github-actions-caching-for-turbo@v1

- name: Build Backend
run: pnpm build:backend

Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ci-pull-requests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ jobs:
- name: Install dependencies
run: pnpm install --frozen-lockfile

- name: Configure Turbo cache
netroy marked this conversation as resolved.
Show resolved Hide resolved
uses: dtinth/setup-github-actions-caching-for-turbo@v1

- name: Restore cached build artifacts
uses: actions/cache/restore@v3.3.1
with:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/units-tests-reusable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ jobs:
- name: Install dependencies
run: pnpm install --frozen-lockfile

- name: Configure Turbo cache
uses: dtinth/setup-github-actions-caching-for-turbo@v1

- name: Build
if: ${{ inputs.cacheKey == '' }}
run: pnpm build
Expand Down
4 changes: 4 additions & 0 deletions turbo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
"dependsOn": ["^build"],
"outputs": ["dist/**"]
},
"build:backend": {},
"build:frontend": {},
"test:backend": {},
"test:frontend": {},
Comment on lines +11 to +14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this alone is enough. we need to define what workspaces to run the build command in. We could try updating https://github.com/n8n-io/n8n/blob/master/package.json#L28 to use turbo run --filter= instead of pnpm --filter=, but unlike pnpm, turbo will still run the tests for editor, because n8n depends on that package.

"typecheck": {},
"format": {},
"lint": {},
Expand Down