Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update @n8n/chat exports and add example images (no-changelog) #8274

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

alexgrozav
Copy link
Contributor

@alexgrozav alexgrozav commented Jan 9, 2024

Summary

  • Fixes package.json exports
  • Adds screenshots for windowed and fullscreen mode
  • Bumps package version

Related tickets and issues

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@alexgrozav alexgrozav self-assigned this Jan 9, 2024
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jan 9, 2024
Copy link

cypress bot commented Jan 9, 2024

3 flaky tests on run #3695 ↗︎

0 330 5 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project: n8n Commit: b25c88717a
Status: Passed Duration: 07:17 💡
Started: Jan 10, 2024 11:08 AM Ended: Jan 10, 2024 11:15 AM
Flakiness  17-sharing.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Sharing > should work for admin role on credentials created by others (also can share it with themselves) Screenshots Video
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Screenshots Video
Flakiness  29-templates.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Templates > should save template id with the workflow Screenshots Video

Review all test suite changes for PR #8274 ↗︎

Copy link
Contributor

github-actions bot commented Jan 9, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit 94c9cd4 into master Jan 10, 2024
48 of 50 checks passed
@alexgrozav alexgrozav deleted the pay-1212-n8nchat-cant-be-used-from-npm branch January 10, 2024 12:50
MiloradFilipovic added a commit that referenced this pull request Jan 11, 2024
* master:
  fix: Adjust cred setup telemetry (no-changelog) (#8294)
  fix(HTTP Request Node): Delete `response.request` only when it's a valid circular references (#8293)
  fix: Properly output saml validation errors (#8284)
  🚀 Release 1.24.0 (#8290)
  feat(editor): Migrate deviceSupportHelpers mixin to useDeviceSupport composable (no-changelog) (#8289)
  fix: Store workflow settings when saving an execution (#8288)
  fix(MySQL Node): Only escape table names when needed (#8246)
  feat(Google Sheets Node): Add "By Name" option to selector for Sheets (#8241)
  feat(MongoDB Node): Add support for TLS (#8266)
  feat: Update @n8n/chat exports and add example images (no-changelog) (#8274)
  ci: Add support for optionally including ARM64 support in custom images (no-changelog) (#8286)
  ci: Update Cypress & increase amount of e2e containers (#8282)
  fix(Monday.com Node): Migrate to api 2023-10 (#8254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants