Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add support for optionally including ARM64 support in custom images (no-changelog) #8286

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Jan 10, 2024

This change adds a checkbox in the dispatch dialog, which when enabled, also includes ARM64 support.
image

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jan 10, 2024
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jan 10, 2024

1 flaky test on run #3697 ↗︎

0 330 5 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: b1aa35f6ed
Status: Passed Duration: 04:18 💡
Started: Jan 10, 2024 11:50 AM Ended: Jan 10, 2024 11:54 AM
Flakiness  cypress/e2e/29-templates.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Templates > should save template id with the workflow Screenshots Video

Review all test suite changes for PR #8286 ↗︎

@netroy netroy merged commit b31fcdb into master Jan 10, 2024
27 of 29 checks passed
@netroy netroy deleted the arm64-custom-images branch January 10, 2024 11:57
MiloradFilipovic added a commit that referenced this pull request Jan 11, 2024
* master:
  fix: Adjust cred setup telemetry (no-changelog) (#8294)
  fix(HTTP Request Node): Delete `response.request` only when it's a valid circular references (#8293)
  fix: Properly output saml validation errors (#8284)
  🚀 Release 1.24.0 (#8290)
  feat(editor): Migrate deviceSupportHelpers mixin to useDeviceSupport composable (no-changelog) (#8289)
  fix: Store workflow settings when saving an execution (#8288)
  fix(MySQL Node): Only escape table names when needed (#8246)
  feat(Google Sheets Node): Add "By Name" option to selector for Sheets (#8241)
  feat(MongoDB Node): Add support for TLS (#8266)
  feat: Update @n8n/chat exports and add example images (no-changelog) (#8274)
  ci: Add support for optionally including ARM64 support in custom images (no-changelog) (#8286)
  ci: Update Cypress & increase amount of e2e containers (#8282)
  fix(Monday.com Node): Migrate to api 2023-10 (#8254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants