fix: Prevent NodeApiError rewraping (no-changelog)

packages/workflow/src/errors/node-api.error.ts

@@ -31,6 +31,7 @@ export interface NodeOperationErrorOptions {
 	messageMapping?: { [key: string]: string }; // allows to pass custom mapping for error messages scoped to a node
 	functionality?: Functionality;
 	type?: string;
+	allowRewrapping?: boolean;
 }
 
 interface NodeApiErrorOptions extends NodeOperationErrorOptions {
@@ -113,7 +114,7 @@ const STATUS_CODE_MESSAGES: IStatusCodeMessages = {
  * with an HTTP error code, an error message and a description.
  */
 export class NodeApiError extends NodeError {
-	httpCode: string | null;
+	httpCode: string | null = null;
 
 	// eslint-disable-next-line complexity
 	constructor(
@@ -129,8 +130,13 @@ export class NodeApiError extends NodeError {
 			level,
 			functionality,
 			messageMapping,
+			allowRewrapping: allowRewraping,
 		}: NodeApiErrorOptions = {},
 	) {
+		if (errorResponse instanceof NodeApiError && !allowRewraping) {
+			return errorResponse;
+		}
+
 		super(node, errorResponse);
 
 		this.addToMessages(errorResponse.message as string);

packages/workflow/src/errors/node-operation.error.ts

@@ -13,9 +13,13 @@ export class NodeOperationError extends NodeError {
 		error: Error | string | JsonObject,
 		options: NodeOperationErrorOptions = {},
 	) {
+		if (error instanceof NodeOperationError && !options.allowRewrapping) {
+			return error;
+		}
 		if (typeof error === 'string') {
 			error = new Error(error);
 		}
+
 		super(node, error);
 
 		if (error instanceof NodeError && error?.messages?.length) {

packages/workflow/test/errors/node.error.test.ts

@@ -9,8 +9,8 @@ describe('NodeError', () => {
 	it('should update re-wrapped error level and message', () => {
 		const apiError = new NodeApiError(node, { message: 'Some error happened', code: 500 });
 		const opsError = new NodeOperationError(node, mock(), { message: 'Some operation failed' });
-		const wrapped1 = new NodeOperationError(node, apiError);
-		const wrapped2 = new NodeOperationError(node, opsError);
+		const wrapped1 = new NodeOperationError(node, apiError, { allowRewrapping: true });
+		const wrapped2 = new NodeOperationError(node, opsError, { allowRewrapping: true });
 
 		expect(wrapped1.level).toEqual('error');
 		expect(wrapped1.message).toEqual('The service was not able to process your request');