fix: Prevent NodeApiError rewraping (no-changelog) #9627
Conversation
michael-radency
added
node/improvement
| @@ -63,6 +63,7 @@ export async function activeCampaignApiRequest( | |||
| return responseData[dataKey] as IDataObject; | |||
| } | |||
| } catch (error) { | |||
| if (error instanceof NodeApiError) throw error; | |||
There was a problem hiding this comment.
there must be a better way to do this instead of having to repeat this so many times.
perhaps we can try moving this check inside the NodeApiError constructor.
There was a problem hiding this comment.
I did consider this, but what if we actually want to re-wrap error? and if we decide to do that for NodeApiError we probably want same policy for other error types
Despite a lot of files changed this would be less invasive and better for performance, as it's simple check
updated pr to disable errors re-wrapping
This reverts commit d70d041.
…do-not-re-wrap-error-in-nodes-api-request-function
…do-not-re-wrap-error-in-nodes-api-request-function
…do-not-re-wrap-error-in-nodes-api-request-function
There was a problem hiding this comment.
The last time we did this, it was done in the NodeError, and that caused a lot of issues. I'm hoping that since these error classes aren't extended, this change doesn't cause those same issues 🤞🏽
2 flaky tests on run #5320 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should retrieve remote options when non-required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9627 ↗︎
|
✅ All Cypress E2E specs passed |
michael-radency
deleted the
node-1392-do-not-re-wrap-error-in-nodes-api-request-function
branch
|
Got released with |
Summary
Do not re-wrap error in node's API request function if it's already NodeApiError
Related tickets and issues
https://linear.app/n8n/issue/NODE-1392/do-not-re-wrap-error-in-nodes-api-request-function-if-its-already
https://linear.app/n8n/issue/NODE-1285/error-display-in-output-pane-improvements