fix(core): Prevent NodeErrors from being wrapped multiple times #8301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
|
This will help here as well. Ref: https://n8nio.sentry.io/issues/4854896768 |
netroy
force-pushed
the
stop-wrapping-errors
branch
from
4017355
to
8fc7385
Compare
ivov
reviewed
Jan 16, 2024
netroy
force-pushed
the
stop-wrapping-errors
branch
from
dc0e936
to
4931730
Compare
2 flaky tests on run #3778 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sharing > should work for admin role on credentials created by others (also can share it with themselves) |
Test Replay
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8301 ↗︎
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will prevent nodes code from creating
NodeOperationErrorwrapping other instances ofNodeError, hopefully reducing the number of layers in error chains.Review / Merge checklist