Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Active toggle incorrectly displayed as inactive in execution view #9778

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jun 17, 2024

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jun 17, 2024
cstuncsik
cstuncsik previously approved these changes Jun 17, 2024
Copy link
Contributor

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

2 similar comments
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@ivov
Copy link
Contributor Author

ivov commented Jun 17, 2024

Copy link
Contributor

✅ No visual regressions found.

Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 551fb6d into master Jun 17, 2024
29 of 30 checks passed
@ivov ivov deleted the pay-1666-active-toggle-incorrectly-displayed-as-inactive-in-execution branch June 17, 2024 16:24
@mutdmour
Copy link
Contributor

Please make sure to add tests @ivov

adrian-martinez-onestic pushed a commit to onesdata/n8n-fork that referenced this pull request Jun 20, 2024
adrian-martinez-onestic pushed a commit to onesdata/n8n-fork that referenced this pull request Jun 20, 2024
This was referenced Jun 20, 2024
@janober
Copy link
Member

janober commented Jun 20, 2024

Got released with n8n@1.47.0

1 similar comment
@janober
Copy link
Member

janober commented Jun 20, 2024

Got released with n8n@1.47.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants