Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Revert header toggle fix #9800

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix(editor): Revert header toggle fix #9800

merged 1 commit into from
Jun 19, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jun 19, 2024

This reverts commit 551fb6d (#9778)

Addressed via #9789

@ivov ivov changed the title fix(core): Revert header toggle fix fix(editor): Revert header toggle fix Jun 19, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jun 19, 2024
Copy link

cypress bot commented Jun 19, 2024

2 flaky tests on run #5574 ↗︎

0 395 0 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: bbf4c2c7f6
Status: Passed Duration: 04:45 💡
Started: Jun 19, 2024 7:51 AM Ended: Jun 19, 2024 7:56 AM
Flakiness  e2e/5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video

Review all test suite changes for PR #9800 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 11fe48b into master Jun 19, 2024
27 checks passed
@ivov ivov deleted the revert-9778 branch June 19, 2024 08:03
adrian-martinez-onestic pushed a commit to onesdata/n8n-fork that referenced this pull request Jun 20, 2024
adrian-martinez-onestic pushed a commit to onesdata/n8n-fork that referenced this pull request Jun 20, 2024
This was referenced Jun 20, 2024
@janober
Copy link
Member

janober commented Jun 20, 2024

Got released with n8n@1.47.0

1 similar comment
@janober
Copy link
Member

janober commented Jun 20, 2024

Got released with n8n@1.47.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants