-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IE clipboard support by using a polyfill lib #123
Conversation
6700af3
to
9e9b099
Compare
I like this a lot, this is the most minimal change I've seen to support IE so the PR is definitely welcome. |
Clipboard API has been replaced by a clipboard library to support IE while maintaining the same behaviour. The copy/paste actions are looked for on key down. Also adds babel-polyfill to ensure Promises and other stuff work as expected.
9e9b099
to
0486d75
Compare
@nadbm Nice to hear, glad you want to accept it 👍 Would you mind fixing the failing tests? Unfortunately it's beyond my skills. Best regards |
Hi @nadbm, this PR fixes my issue with IE. any progress here? Thanks 🙂 |
Hey @nadbm it would be a huge help if this PR would be merged. It also fixes issues with IE for me. Are you planing on margin it? Thanks!! :) |
Hi @nadbm, any update here? |
@ankerek Unfortunately, I am unable to update the current test suite using the clipboard polyfill. The api's used on the polyfill are not readily available on JSDOM. I will look |
@nadbm We believe in you! Can't wait for it to be merged 😄 |
Is there any status about getting these tests passing? |
@tmreay Unfortunately, current tests are done using JSDOM, and that does not support the APIs given by clipboard-polyfill jsdom/jsdom#1742 I am keeping this PR open for anyone trying to use this on IE. Im not actively working on this project so if there are PRs that would fix these tests, I will merge them. |
Merged PR #162 |
Created due to issue #84
Clipboard API has been replaced by a clipboard
library to support IE while maintaining the same
behaviour. The copy/paste actions are looked for
on key down. Also adds babel-polyfill to ensure
Promises and other stuff work as expected.
Do you find this solution applicable? I know the Clipboard API is great but unfortunately lacks support for IE which seems to be sought out for.
I haven't fixed the Datasheet tests yet as I would first like to hear what you think about the solution.
Best regards