Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IE clipboard support by using a polyfill lib #123

Closed
wants to merge 1 commit into from

Conversation

partynikko
Copy link

Created due to issue #84

Clipboard API has been replaced by a clipboard
library to support IE while maintaining the same
behaviour. The copy/paste actions are looked for
on key down. Also adds babel-polyfill to ensure
Promises and other stuff work as expected.

Do you find this solution applicable? I know the Clipboard API is great but unfortunately lacks support for IE which seems to be sought out for.

I haven't fixed the Datasheet tests yet as I would first like to hear what you think about the solution.

Best regards

@nadbm
Copy link
Owner

nadbm commented Sep 26, 2018

I like this a lot, this is the most minimal change I've seen to support IE so the PR is definitely welcome.
Thanks @Nikkop

Clipboard API has been replaced by a clipboard
library to support IE while maintaining the same
behaviour. The copy/paste actions are looked for
on key down. Also adds babel-polyfill to ensure
Promises and other stuff work as expected.
@partynikko
Copy link
Author

@nadbm Nice to hear, glad you want to accept it 👍

Would you mind fixing the failing tests? Unfortunately it's beyond my skills.

Best regards

@ankerek
Copy link

ankerek commented Oct 23, 2018

Hi @nadbm, this PR fixes my issue with IE. any progress here? Thanks 🙂

@pololitr
Copy link

Hey @nadbm it would be a huge help if this PR would be merged. It also fixes issues with IE for me. Are you planing on margin it? Thanks!! :)
👍

@nadbm
Copy link
Owner

nadbm commented Oct 24, 2018

@ankerek @pololitr I do plan on merging this by next week. I didn't get a chance to update the tests. Feel free to use this branch for now.

@ankerek
Copy link

ankerek commented Nov 7, 2018

Hi @nadbm, any update here?

@nadbm
Copy link
Owner

nadbm commented Nov 13, 2018

@ankerek Unfortunately, I am unable to update the current test suite using the clipboard polyfill. The api's used on the polyfill are not readily available on JSDOM. I will look

@partynikko
Copy link
Author

@nadbm We believe in you! Can't wait for it to be merged 😄

@tmreay
Copy link

tmreay commented Mar 19, 2019

Is there any status about getting these tests passing?

@nadbm
Copy link
Owner

nadbm commented Mar 19, 2019

@tmreay Unfortunately, current tests are done using JSDOM, and that does not support the APIs given by clipboard-polyfill

jsdom/jsdom#1742
jsdom/jsdom#1568

I am keeping this PR open for anyone trying to use this on IE. Im not actively working on this project so if there are PRs that would fix these tests, I will merge them.

@nadbm
Copy link
Owner

nadbm commented Sep 14, 2019

Merged PR #162

@nadbm nadbm closed this Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants