Hotfix/ie paste #162
Merged
Hotfix/ie paste #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadbm
reviewed
Aug 19, 2019
src/DataSheet.js
Outdated
| // Listen for Ctrl + V in case of IE | ||
| if (isIE) { | ||
| var thisContext = this | ||
| document.addEventListener('keydown', function (e){ |
There was a problem hiding this comment.
you can use lamda function here not to have an extra var here for passing context. Or bind the function
nadbm
reviewed
Aug 19, 2019
src/DataSheet.js
Outdated
| // Listen for Ctrl + V in case of IE | ||
| if (isIE) { | ||
| var thisContext = this | ||
| document.addEventListener('keydown', function (e){ |
There was a problem hiding this comment.
On component will unmount, remove the event listener as well
nadbm
requested changes
Aug 19, 2019
There was a problem hiding this comment.
Thank you for the pr @bsbimalbose , if you can fix the comments, will go ahead and merge this pr
|
@nadbm I've updated the code. Please merge this PR |
nadbm
approved these changes
Sep 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the multi-cell paste issue in IE