Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix endless loop in 1-Wire during ID search #1501

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Fix endless loop in 1-Wire during ID search #1501

merged 1 commit into from
Nov 12, 2019

Conversation

up-streamer
Copy link
Contributor

@up-streamer up-streamer commented Nov 12, 2019

Description

  • Correct the comparison at the end of FindNext() to terminate de search.
  • This fix applies for ESP32 and STM32
  • The comparison was not was done in correct way, as per Maxim APP note AN187.
    from: if (romBitIndex < (65 || lastcrc8)
    goes to: if ((romBitIndex < 65) || (lastcrc8 != 0))

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: up-streamer up_stream@hotmail.com

 more than 2 devices on the bus.

This fix is for ESP32 and STM32
@nfbot
Copy link
Member

nfbot commented Nov 12, 2019

Hi @up-streamer,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now!

LGTM. 👏

@josesimoes josesimoes added Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: bug labels Nov 12, 2019
@up-streamer
Copy link
Contributor Author

Thanks!
Living and learning.

@josesimoes josesimoes merged commit b774ca6 into nanoframework:develop Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OneWire going into endless loop when seaching devices
4 participants