-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOS XE Traceroute ttl #1320
Comments
During the analysis of this problem I also noticed that there is no possiblity to skip the ttl parameter. |
During the analysis I discovered another small issue with the traceroute. If we want to skip the ttl parameter of the command string ttl in my opinion the logical input value for ttl would be None. I checked the other drivers and eos and iosxr seems to have similiar issues. What do you think about this? |
I'm not sure I'm following, where does So if you want to use a lower value than 255, pass in the argument, otherwise this is that value it should use. Now, if the syntax should be |
Sorry for the confusion. I'll try to be a little bit more consise. In my opinion the best way to do that would be to pass None into the traceroute function. In the most drivers this method is even (partially) implemented by the |
@mirceaulinic Is there anything I can do to push this forward? |
Hi @MatthiasGabriel. I think the behaviour shouldn't change from one driver to another because of the platform differences. In particular:
Then we just ignore the
That would break the consistency of the NAPALM API. Back to the core issue, regarding IOS-XE devices that don't support the TTL argument, should identify which are those particular platforms or versions and nest this |
Hi @mirceaulinic thanks for your response. The core issue is that if IOS allows to specify a TTL, it requires a min ttl as shown in the screenshots. Regarding the consistency of the NAPALM API, some drivers(e.g. junos, nxos) already support ttl=None, while others run into exceptional behaviour due to the calculations. |
I see, wasn't aware some platforms require a minimum TTL. We should probably just revert #1174 as it seems to rather be based on feelings than facts. Thoughts? |
I think the fix which renamed timeout to ttl was okay, however the second change was not. |
…um_ttl Set minimum ttl to zero to fix issue #1320
As #1321 is now merged, was there anything else you wanted to discuss here @MatthiasGabriel ? |
Hi @mirceaulinic |
Description of Issue/Question
The command string created when calling traceroute on IOS device leads to an incomplete command and to an empy
success
in the result.The problem is that the generated command in the IOS driver is missing the minimum ttl.
The output from the device is then
'^% Invalid input detected at \'^\' marker.
I noticed that the minimum ttl got removed in the pr #1174. Does IOS XE implement different traceroute commands on different versions?
Did you follow the steps from https://github.com/napalm-automation/napalm#faq
(Place an
x
between the square brackets where applicable)Setup
napalm version
(Paste verbatim output from
pip freeze | grep napalm
between quotes below)Network operating system version
(Paste verbatim output from
show version
- or equivalent - between quotes below)Steps to Reproduce the Issue
Error Traceback
(Paste the complete traceback of the exception between quotes below)
The text was updated successfully, but these errors were encountered: