-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set minimum ttl to zero to fix issue #1320 #1321
Set minimum ttl to zero to fix issue #1320 #1321
Conversation
@@ -3284,7 +3284,7 @@ def traceroute( | |||
command += " source {}".format(source) | |||
if ttl: | |||
if isinstance(ttl, int) and 0 <= ttl <= 255: | |||
command += " ttl {}".format(str(ttl)) | |||
command += " ttl 0 {}".format(str(ttl)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this syntax is supported on every IOS version. Did you give it a try @MatthiasGabriel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mirceaulinic Any suggestions which versions I should check?
Also as now mentioned in the issue #1320 I'm not sure about the value 0 either. In my opinion 1 seems like the "default".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gah, not sure what to say, I fortunately don't have a Cisco IOS to check this out. Perhaps @ktbyers would have more input on this matter? I'd also suggest you to engage with the community and see what other IOS users think about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your feedback @mirceaulinic
During the day I added some new findings to the issue #1320
Add minimum ttl to ios traceroute command.
Fixes Issue #1320