Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum ttl to zero to fix issue #1320 #1321

Merged
merged 4 commits into from
Jan 14, 2021
Merged

Set minimum ttl to zero to fix issue #1320 #1321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
190e79c
Set minimum ttl to zero to fix issue #1320
MatthiasGabriel Nov 12, 2020
ffe14d0
change testfile to include minttl
MatthiasGabriel Nov 13, 2020
b867014
Merge branch 'develop' into bugfix/traceroute_minimum_ttl
mirceaulinic Jan 14, 2021
84148d1
Merge branch 'develop' into bugfix/traceroute_minimum_ttl
mirceaulinic Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion napalm/ios/ios.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3289,7 +3289,7 @@ def traceroute(
command += " source {}".format(source)
if ttl:
if isinstance(ttl, int) and 0 <= ttl <= 255:
command += " ttl {}".format(str(ttl))
command += " ttl 0 {}".format(str(ttl))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this syntax is supported on every IOS version. Did you give it a try @MatthiasGabriel?

Copy link
Contributor Author

@MatthiasGabriel MatthiasGabriel Nov 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirceaulinic Any suggestions which versions I should check?
Also as now mentioned in the issue #1320 I'm not sure about the value 0 either. In my opinion 1 seems like the "default".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah, not sure what to say, I fortunately don't have a Cisco IOS to check this out. Perhaps @ktbyers would have more input on this matter? I'd also suggest you to engage with the community and see what other IOS users think about it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback @mirceaulinic
During the day I added some new findings to the issue #1320

if timeout:
# Timeout should be an integer between 1 and 3600
if isinstance(timeout, int) and 1 <= timeout <= 3600:
Expand Down
0 .../traceroute_8_8_8_8_ttl_255_timeout_2.txt → ...raceroute_8_8_8_8_ttl_0_255_timeout_2.txt
100755 → 100644
View file
Open in desktop
File renamed without changes.