-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CF_UnionArgs_Payload_t elements dword and hword not used, union not necessary #288
Open
3 tasks done
Open
3 tasks done
Labels
Comments
2 tasks
2 tasks
dzbaker
added a commit
that referenced
this issue
Mar 13, 2023
…ayload_t-union Fix #288, Remove unnecessary CF_UnionArgs_Payload_t union
Initial PR solving this issue is reverted by #395. Reopening to be considered for Equuleus-rc2. |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist (Please check before submitting)
Is your feature request related to a problem? Please describe.
dword and hword are not used in the
CF_UnionArgs_Payload_t
union, only byte:CF/fsw/src/cf_msg.h
Lines 159 to 169 in 0774746
Describe the solution you'd like
Remove unnecessary union
Describe alternatives you've considered
CF_UnionArgsCmd_t
is somewhat out of family in that it specifies unnecessary payload elements for some of the commands. The only common benefit seems to be byte 0 which is channel, supporting all channels generically with 255. Consider untangling all the layers of abstraction and go back to simple command processing.Additional context
None
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: