Fix #288, Remove unnecessary CF_UnionArgs_Payload_t
union
#400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Fixes CF_UnionArgs_Payload_t elements dword and hword not used, union not necessary #288
CF_UnionArgs_Payload_t
has been removed, given that only a single member of the 3 is used in CF. That member variable -byte
- has been moved into theCF_UnionArgsCmd_t
struct, which was the only place whereCF_UnionArgs_Payload_t
was used.Re-introduced from Fix #288, Remove unnecessary CF_UnionArgs_Payload_t union #341. Move PR #341 into Equuleus-rc2 #393, Fix #393, revert merge of PR #341. #395 reverted this PR due to integration issues. Resubmitting here for consideration in next release.
Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes
No impact on logic.
Code is simplified and clearer.
Contributor Info
Avi Weiss @thnkslprpt