Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extraneous assignments to CFE_SUCCESS #365

Closed
2 tasks done
thnkslprpt opened this issue Feb 15, 2023 · 0 comments · Fixed by #366
Closed
2 tasks done

Extraneous assignments to CFE_SUCCESS #365

thnkslprpt opened this issue Feb 15, 2023 · 0 comments · Fixed by #366
Labels
enhancement Equuleus-rc1
Milestone
Equuleus

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
CF has a few extraneous assignments to CFE_SUCCESS as in nasa/HS#10

Code snips

CF/fsw/src/cf_app.c

Lines 151 to 156 in 19c18b9

int32 CF_TableInit(void)
{
int32 status = CFE_SUCCESS;
status = CFE_TBL_Register(&CF_AppData.config_handle, CF_CONFIG_TABLE_NAME, sizeof(CF_ConfigTable_t),
CFE_TBL_OPT_SNGL_BUFFER | CFE_TBL_OPT_LOAD_DUMP, CF_ValidateConfigTable);

CF/fsw/src/cf_cfdp.c

Lines 1324 to 1331 in 19c18b9

static int32 CF_CFDP_PlaybackDir_Initiate(CF_Playback_t *p, const char *src_filename, const char *dst_filename,
CF_CFDP_Class_t cfdp_class, uint8 keep, uint8 chan, uint8 priority,
CF_EntityId_t dest_id)
{
int32 ret = CFE_SUCCESS;
/* make sure the directory can be open */
ret = OS_DirectoryOpen(&p->dir_id, src_filename);

Expected behavior
Remove assignments - unnecessary code.

Reporter Info
Avi Weiss @thnkslprpt
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Feb 16, 2023
@thnkslprpt
Fix nasa#365, Remove extraneous assignments to CFE_SUCCESS
3444ff4
@thnkslprpt thnkslprpt mentioned this issue Feb 16, 2023
Merged
2 tasks
dzbaker added a commit that referenced this issue Mar 9, 2023
@dzbaker
Merge pull request #366 from thnkslprpt/fix-365-remove-extraneous-ass…
cb2977c 
…ignments

Fix #365, Remove extraneous assignments to CFE_SUCCESS
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Mar 9, 2023
@thnkslprpt
Squashed commit of the following:
ffc7ec5 
commit 3454b3501d05c1e538a9068572b70d2ba35329f3
Author: Avi <thnkslprpt@gmail.com>
Date:   Fri Mar 10 09:32:15 2023 +1000

    Fix nasa#105, Remove 'dummy' from variable names

commit e18bde9
Merge: 8fb8d9c cb2977c
Author: Avi <thnkslprpt@gmail.com>
Date:   Fri Mar 10 08:41:21 2023 +1000

    Merge branch 'main' into fix-105-remove-dummy-from-variable-names

commit cb2977c
Merge: 4ce1aa9 3444ff4
Author: dzbaker <dylan.z.baker@nasa.gov>
Date:   Thu Mar 9 15:23:53 2023 -0500

    Merge pull request nasa#366 from thnkslprpt/fix-365-remove-extraneous-assignments

    Fix nasa#365, Remove extraneous assignments to CFE_SUCCESS

commit 4ce1aa9
Merge: c44e372 dec4440
Author: dzbaker <dylan.z.baker@nasa.gov>
Date:   Thu Mar 9 15:20:08 2023 -0500

    Merge pull request nasa#333 from thnkslprpt/fix-109-variable-declarations

    Fix nasa#109, Move variables declared mid-function to the top

commit 8fb8d9c
Author: Avi <thnkslprpt@gmail.com>
Date:   Thu Feb 23 12:45:59 2023 +1000

    Fix nasa#105, Remove 'dummy' from variable names

commit 3444ff4
Author: Avi <thnkslprpt@gmail.com>
Date:   Thu Feb 16 10:39:06 2023 +1000

    Fix nasa#365, Remove extraneous assignments to CFE_SUCCESS

commit dec4440
Author: Avi Weiss <thnkslprpt@gmail.com>
Date:   Mon Dec 26 16:23:48 2022 +1100

    Fix nasa#109, Move variables declared mid-function to the top

    commit 4e1bb97
    Author: Avi Weiss <thnkslprpt@gmail.com>
    Date:   Mon Dec 26 16:14:26 2022 +1100

        Typo from merge from main

    commit 57ab176
    Merge: e151abd 8368adc
    Author: Avi <thnkslprpt@gmail.com>
    Date:   Mon Dec 26 15:16:21 2022 +1100

        Merge branch 'main' into fix-109-variable-declarations

    commit e151abd
    Author: Avi <thnkslprpt@gmail.com>
    Date:   Thu Oct 13 18:34:51 2022 +1000

        Fix nasa#109, Move variables declared mid-function to the top
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Mar 10, 2023
@thnkslprpt
Squashed commit of the following:
c23dcd5 
commit 4ef9460
Author: Avi <thnkslprpt@gmail.com>
Date:   Fri Mar 10 10:10:40 2023 +1000

    Formatting

commit e18bde9
Merge: 8fb8d9c cb2977c
Author: Avi <thnkslprpt@gmail.com>
Date:   Fri Mar 10 08:41:21 2023 +1000

    Merge branch 'main' into fix-105-remove-dummy-from-variable-names

commit cb2977c
Merge: 4ce1aa9 3444ff4
Author: dzbaker <dylan.z.baker@nasa.gov>
Date:   Thu Mar 9 15:23:53 2023 -0500

    Merge pull request nasa#366 from thnkslprpt/fix-365-remove-extraneous-assignments

    Fix nasa#365, Remove extraneous assignments to CFE_SUCCESS

commit 4ce1aa9
Merge: c44e372 dec4440
Author: dzbaker <dylan.z.baker@nasa.gov>
Date:   Thu Mar 9 15:20:08 2023 -0500

    Merge pull request nasa#333 from thnkslprpt/fix-109-variable-declarations

    Fix nasa#109, Move variables declared mid-function to the top

commit 8fb8d9c
Author: Avi <thnkslprpt@gmail.com>
Date:   Thu Feb 23 12:45:59 2023 +1000

    Fix nasa#105, Remove 'dummy' from variable names

commit 3444ff4
Author: Avi <thnkslprpt@gmail.com>
Date:   Thu Feb 16 10:39:06 2023 +1000

    Fix nasa#365, Remove extraneous assignments to CFE_SUCCESS

commit dec4440
Author: Avi Weiss <thnkslprpt@gmail.com>
Date:   Mon Dec 26 16:23:48 2022 +1100

    Fix nasa#109, Move variables declared mid-function to the top

    commit 4e1bb97
    Author: Avi Weiss <thnkslprpt@gmail.com>
    Date:   Mon Dec 26 16:14:26 2022 +1100

        Typo from merge from main

    commit 57ab176
    Merge: e151abd 8368adc
    Author: Avi <thnkslprpt@gmail.com>
    Date:   Mon Dec 26 15:16:21 2022 +1100

        Merge branch 'main' into fix-109-variable-declarations

    commit e151abd
    Author: Avi <thnkslprpt@gmail.com>
    Date:   Thu Oct 13 18:34:51 2022 +1000

        Fix nasa#109, Move variables declared mid-function to the top
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Equuleus-rc1
Projects
None yet
Milestone
Equuleus
Development

Successfully merging a pull request may close this issue.

Fix #365, Remove extraneous assignments to CFE_SUCCESS thnkslprpt/CF
3 participants
@thnkslprpt @dmknutsen @chillfig