-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #365, Remove extraneous assignments to CFE_SUCCESS #366
Merged
dzbaker
merged 1 commit into
nasa:main
from
thnkslprpt:fix-365-remove-extraneous-assignments
Mar 9, 2023
Merged
Fix #365, Remove extraneous assignments to CFE_SUCCESS #366
dzbaker
merged 1 commit into
nasa:main
from
thnkslprpt:fix-365-remove-extraneous-assignments
Mar 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbaker
approved these changes
Mar 2, 2023
jphickey
approved these changes
Mar 9, 2023
thnkslprpt
added a commit
to thnkslprpt/CF
that referenced
this pull request
Mar 9, 2023
commit 3454b3501d05c1e538a9068572b70d2ba35329f3 Author: Avi <thnkslprpt@gmail.com> Date: Fri Mar 10 09:32:15 2023 +1000 Fix nasa#105, Remove 'dummy' from variable names commit e18bde9 Merge: 8fb8d9c cb2977c Author: Avi <thnkslprpt@gmail.com> Date: Fri Mar 10 08:41:21 2023 +1000 Merge branch 'main' into fix-105-remove-dummy-from-variable-names commit cb2977c Merge: 4ce1aa9 3444ff4 Author: dzbaker <dylan.z.baker@nasa.gov> Date: Thu Mar 9 15:23:53 2023 -0500 Merge pull request nasa#366 from thnkslprpt/fix-365-remove-extraneous-assignments Fix nasa#365, Remove extraneous assignments to CFE_SUCCESS commit 4ce1aa9 Merge: c44e372 dec4440 Author: dzbaker <dylan.z.baker@nasa.gov> Date: Thu Mar 9 15:20:08 2023 -0500 Merge pull request nasa#333 from thnkslprpt/fix-109-variable-declarations Fix nasa#109, Move variables declared mid-function to the top commit 8fb8d9c Author: Avi <thnkslprpt@gmail.com> Date: Thu Feb 23 12:45:59 2023 +1000 Fix nasa#105, Remove 'dummy' from variable names commit 3444ff4 Author: Avi <thnkslprpt@gmail.com> Date: Thu Feb 16 10:39:06 2023 +1000 Fix nasa#365, Remove extraneous assignments to CFE_SUCCESS commit dec4440 Author: Avi Weiss <thnkslprpt@gmail.com> Date: Mon Dec 26 16:23:48 2022 +1100 Fix nasa#109, Move variables declared mid-function to the top commit 4e1bb97 Author: Avi Weiss <thnkslprpt@gmail.com> Date: Mon Dec 26 16:14:26 2022 +1100 Typo from merge from main commit 57ab176 Merge: e151abd 8368adc Author: Avi <thnkslprpt@gmail.com> Date: Mon Dec 26 15:16:21 2022 +1100 Merge branch 'main' into fix-109-variable-declarations commit e151abd Author: Avi <thnkslprpt@gmail.com> Date: Thu Oct 13 18:34:51 2022 +1000 Fix nasa#109, Move variables declared mid-function to the top
thnkslprpt
added a commit
to thnkslprpt/CF
that referenced
this pull request
Mar 10, 2023
commit 4ef9460 Author: Avi <thnkslprpt@gmail.com> Date: Fri Mar 10 10:10:40 2023 +1000 Formatting commit e18bde9 Merge: 8fb8d9c cb2977c Author: Avi <thnkslprpt@gmail.com> Date: Fri Mar 10 08:41:21 2023 +1000 Merge branch 'main' into fix-105-remove-dummy-from-variable-names commit cb2977c Merge: 4ce1aa9 3444ff4 Author: dzbaker <dylan.z.baker@nasa.gov> Date: Thu Mar 9 15:23:53 2023 -0500 Merge pull request nasa#366 from thnkslprpt/fix-365-remove-extraneous-assignments Fix nasa#365, Remove extraneous assignments to CFE_SUCCESS commit 4ce1aa9 Merge: c44e372 dec4440 Author: dzbaker <dylan.z.baker@nasa.gov> Date: Thu Mar 9 15:20:08 2023 -0500 Merge pull request nasa#333 from thnkslprpt/fix-109-variable-declarations Fix nasa#109, Move variables declared mid-function to the top commit 8fb8d9c Author: Avi <thnkslprpt@gmail.com> Date: Thu Feb 23 12:45:59 2023 +1000 Fix nasa#105, Remove 'dummy' from variable names commit 3444ff4 Author: Avi <thnkslprpt@gmail.com> Date: Thu Feb 16 10:39:06 2023 +1000 Fix nasa#365, Remove extraneous assignments to CFE_SUCCESS commit dec4440 Author: Avi Weiss <thnkslprpt@gmail.com> Date: Mon Dec 26 16:23:48 2022 +1100 Fix nasa#109, Move variables declared mid-function to the top commit 4e1bb97 Author: Avi Weiss <thnkslprpt@gmail.com> Date: Mon Dec 26 16:14:26 2022 +1100 Typo from merge from main commit 57ab176 Merge: e151abd 8368adc Author: Avi <thnkslprpt@gmail.com> Date: Mon Dec 26 15:16:21 2022 +1100 Merge branch 'main' into fix-109-variable-declarations commit e151abd Author: Avi <thnkslprpt@gmail.com> Date: Thu Oct 13 18:34:51 2022 +1000 Fix nasa#109, Move variables declared mid-function to the top
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Fixes #365
Extraneous assignments to CFE_SUCCESS were removed.
Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes
No change to behavior.
Contributor Info
Avi Weiss @thnkslprpt