Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using an enum for MD error codes #3

Closed
skliper opened this issue Apr 22, 2022 · 0 comments · Fixed by #38
Closed

Consider using an enum for MD error codes #3

skliper opened this issue Apr 22, 2022 · 0 comments · Fixed by #38
Labels
enhancement
Milestone
Equuleus

Comments

@skliper
Copy link
Contributor

skliper commented Apr 22, 2022

In file md_dwell_pkt.c function MD_GetDwellData, all the "-1" status values could be replaced with an enum.

Finding from code review.

Imported from GSFCCFS-1048
thnkslprpt added a commit to thnkslprpt/MD that referenced this issue Oct 23, 2022
@thnkslprpt
Fix nasa#3, Add enum to GetDwellData() to remove magic number error c…
e93ea9b 
…odes
thnkslprpt added a commit to thnkslprpt/MD that referenced this issue Oct 23, 2022
@thnkslprpt
Fix nasa#3, Add enum to remove magic number error codes from GetDwell…
2ce471c 
…Data()
@thnkslprpt thnkslprpt mentioned this issue Oct 23, 2022
Merged
2 tasks
thnkslprpt added a commit to thnkslprpt/MD that referenced this issue Mar 14, 2023
@thnkslprpt
Fix nasa#3, Add enum to remove magic number error codes from GetDwell…
48ba9eb 
…Data()
dzbaker added a commit that referenced this issue Mar 14, 2023
@dzbaker
Merge pull request #38 from thnkslprpt/fix-3-remove-magic-number-erro…
116d298 
…r-codes-in-getdwelldata

Fix #3, Add enum to remove magic number error codes from GetDwellData()
@chillfig chillfig added this to the Equuleus milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Equuleus
Development

Successfully merging a pull request may close this issue.

Fix #3, Add enum to remove magic number error codes from GetDwellData() thnkslprpt/MD
2 participants
@skliper @chillfig