Fix #3, Add enum to remove magic number error codes from GetDwellData() #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -158,27 +158,27 @@ | |||
| switch (NumBytes) | |||
| { | |||
| case 1: | |||
| if (CFE_PSP_MemRead8(DwellAddress, (uint8 *)&MemReadVal) != CFE_SUCCESS) | |||
| if (CFE_PSP_MemRead8(DwellAddress, (uint8 *)&MemReadVal) != CFE_PSP_SUCCESS) | |||
Check warning
Code scanning / CodeQL-coding-standard
Side effect in a Boolean expression
| } | ||
| break; | ||
| case 2: | ||
| if (CFE_PSP_MemRead16(DwellAddress, (uint16 *)&MemReadVal) != CFE_SUCCESS) | ||
| if (CFE_PSP_MemRead16(DwellAddress, (uint16 *)&MemReadVal) != CFE_PSP_SUCCESS) |
Check warning
Code scanning / CodeQL-coding-standard
Side effect in a Boolean expression
| } | ||
| break; | ||
| case 4: | ||
| if (CFE_PSP_MemRead32(DwellAddress, &MemReadVal) != CFE_SUCCESS) | ||
| if (CFE_PSP_MemRead32(DwellAddress, &MemReadVal) != CFE_PSP_SUCCESS) |
Check warning
Code scanning / CodeQL-coding-standard
Side effect in a Boolean expression
|
CCB 27 October 2022: Approved pending workflow failure resolution. |
thnkslprpt
force-pushed
the
fix-3-remove-magic-number-error-codes-in-getdwelldata
branch
from
2ce471c
to
48ba9eb
Compare
All passing now @dzbaker ;-) |
thnkslprpt
deleted the
fix-3-remove-magic-number-error-codes-in-getdwelldata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Fixes #3
Adds enum to represent error return codes from dwell address read functions.
Testing performed
GitHub CI actions (incl. build + run, MD unit tests) all passing successfully.
Expected behavior changes
No change in logic.
Removes magic number error codes, making error types easier to identify.
Contributor Info
Avi Weiss @thnkslprpt