Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ground truth bug + limit probability of tf warning while maintain… #537

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

marinagmoreira
Copy link
Member

…ing publishing rate

@marinagmoreira marinagmoreira requested a review from bcoltin August 23, 2022 23:40
@marinagmoreira marinagmoreira linked an issue Aug 23, 2022 that may be closed by this pull request
Copy link
Member

@bcoltin bcoltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am probably missing something, but is the only difference in gazebo versions here that GetWorldPose became WorldPose? If so, why don't we assign the world pose to a temporary object and just put the # ifs only around that so we can make these kinds of mistakes less likely in the future?

@marinagmoreira
Copy link
Member Author

I am probably missing something, but is the only difference in gazebo versions here that GetWorldPose became WorldPose? If so, why don't we assign the world pose to a temporary object and just put the # ifs only around that so we can make these kinds of mistakes less likely in the future?

sounds good, we could add it to astrobee_gazebo.cc, do you want to do it on this PR or open a separate issue?

@bcoltin
Copy link
Member

bcoltin commented Aug 24, 2022

Whatever you think is best! If you want to do a separate issue then feel free to go ahead and merge this one.

@marinagmoreira marinagmoreira merged commit 0b48302 into nasa:develop Aug 24, 2022
@marinagmoreira marinagmoreira deleted the fix_ground_truth_bug branch August 24, 2022 17:39
luisa-mao pushed a commit to luisa-mao/astrobee-1 that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The use of ground truth localisation leads to errors
2 participants