Possible uninitialized variable (false alarms) - static analysis

[skliper]

Is your feature request related to a problem? Please describe.
All false alarms based on logic, but easy to squash (just initialize).

This one could be avoided w/ simple refactor (move success logic into if) which reduces to one return location (preferred coding style):

cFE/fsw/cfe-core/src/time/cfe_time_api.c

Line 727 in c708d64

uint32 AppIndex;

Just initialize:

cFE/fsw/cfe-core/src/es/cfe_es_apps.c

Line 648 in c708d64

CFE_ResourceId_t PendingResourceId;

cFE/fsw/cfe-core/src/sb/cfe_sb_api.c

Line 108 in c708d64

CFE_ResourceId_t PendingPipeId;

cFE/fsw/cfe-core/src/sb/cfe_sb_task.c

Line 923 in c708d64

CFE_SB_PipeD_t *pipedptr;

Likely resolved if OS_OpenCreate_t initialized the file descriptor on failure:

cFE/fsw/cfe-core/src/es/cfe_es_apps.c

Line 83 in c708d64

osal_id_t AppFile;

cFE/fsw/cfe-core/src/es/cfe_es_task.c

Line 1341 in 672b2dc

osal_id_t FileDescriptor;

cFE/fsw/cfe-core/src/es/cfe_es_syslog.c

Line 471 in 672b2dc

osal_id_t fd;

Describe the solution you'd like
See above

Describe alternatives you've considered
None

Additional context
CodeQL warnings, wait until #972 is resolved

Requester Info
Jacob Hageman - NASA/GSFC

[skliper]

Note - majority of the osal_id_t file false alarms could be avoided if OS_OpenCreate set the descriptor invalid (OS_OBJECT_ID_UNDEFINED) on failure.

[skliper]

Note the cfe_sb_task.c one has been refactored, wasn't obviously an issue so I'll leave for next round of analysis