Fix #833, Initialize file descriptor in OS_OpenCreate #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
force-pushed
the
fix833-init_filedes
branch
from
ab99223
to
7b5c287
Compare
skliper
force-pushed
the
fix833-init_filedes
branch
from
7b5c287
to
d1c4e8f
Compare
zanzaben
approved these changes
Mar 1, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Mar 4, 2021
Combines: - nasa/cFE#1196 - nasa/osal#835 - nasa/elf2cfetbl#72 Includes: - nasa/cFE#1154 - nasa/cFE#935 - nasa/cFE#1179 - nasa/cFE#1140 - nasa/cFE#1178 - nasa/cFE#1197 - nasa/osal#834 - nasa/osal#826 - nasa/osal#827 - nasa/osal#829 - nasa/osal#824 - nasa/elf2cfetbl#71
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#818, Return message address from CFE_SB_SendMsg stub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #833 - Initializes the file descriptor (output parameter) for all cases in OS_OpenCreate
Avoids various "possible uninitialized variable" warnings for routines that utilize this API.
Testing performed
Build and execute unit tests, passed
Expected behavior changes
Avoids static analysis warning, output never unset.
System(s) tested on
Additional context
nasa/cFE#1185
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC