osal Integration candidate: 2021-03-02 #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #833, Initialize file descriptor in OS_OpenCreate
Fix #795, Add uncovered vxworks source files to coverage statistics
Fix #780, restrict permissions on file create
Fix #828, fix comment style
Adds 4 version API calls: const char *OS_GetVersionString(void); const char *OS_GetVersionCodeName(void); void OS_GetVersionNumber(uint8[4]); uint32 OS_GetBuildNumber(void); These return the values of current macros in osapi-version.h. The accessor function should be the preferred way to get the OSAL version info (vs. using macro directly) as it is evaluated at OSAL library compile time, rather than application compile time, and thus will remain correct in the event that OSAL is relinked without recompiling the application.
Fix #821, add accessor functions for version strings Fix format in `osapi-utstub-version.c`
astrogeco
force-pushed
the
integration-candidate
branch
from
a59116a
to
75105a8
Compare
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Mar 4, 2021
Combines: - nasa/cFE#1196 - nasa/osal#835 - nasa/elf2cfetbl#72 Includes: - nasa/cFE#1154 - nasa/cFE#935 - nasa/cFE#1179 - nasa/cFE#1140 - nasa/cFE#1178 - nasa/cFE#1197 - nasa/osal#834 - nasa/osal#826 - nasa/osal#827 - nasa/osal#829 - nasa/osal#824 - nasa/elf2cfetbl#71
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fixup the table build targets so it will be invoked for both static and dynamic apps. Improve the prep log messages to indicate the targets that tables will be built for for both static and dynamic apps.
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#835, build tables for static apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #833 - Initializes the file descriptor (output parameter) for all cases in OS_OpenCreate
Fix #795 - Adds all the currently possible source files for
VxWorksto coverage statistics and adds coverage testsFix #780, restrict permissions on file create
Fix #828, Change the comment style
Fix #821, OSAL should have a "OS_GetVersionString()" function
Testing performed
See https://github.com/nasa/cFS/pull/204/checks
Expected behavior changes
PR #834 - Avoids various "possible uninitialized variable" warnings for routines that utilize this API.
PR #826 - Renames
sockaddr*structures tosa*to deconflict from structure name inos-impl-bsd-sockets.c. AddsOS_NETWORK_SUPPORTS_IPV6toos-impl-bsd-sockets.ccompilation. Renamesbsd-select-stubs.ctosys-select-stubs.c. Coverage now includes all currently possible files in VxWorks buildPR #827 - Resolves CodeQL security warning by restricting permissions on file create.
PR #829 - Changes comments using "cpp" comment style to "c" style
PR #824 - Adds new accessor functions APIs to get version strings and return the values of string macros defined in
osapi-version.h.OS_VERSIONmacro - this is the semantic version without any extra detail. This is returned byOS_GetVersion().OS_VERSION_STRINGmacro - this has extra detail like the most recent official release. This is returned byOS_GetVersionDescription().OS_GetVersionDescription().These functions are the preferred way to get the OSAL version string, from now on users should avoid using the macro definitions as it is evaluated at OSAL library compile time, rather than application compile time, and thus will remain correct in the event that OSAL is relinked without recompiling the application.
Adds
osapi-version.cto implement these 3 calls and associated coverage test. This allows the version.c file to be auto-generated in the future.System(s) tested on
Ubuntu 18.04
Additional context
Part of nasa/cFS#204
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@skliper
@jphickey
@zanzaben