Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ comment style and commented out code violations #828

Closed
zanzaben opened this issue Feb 23, 2021 · 0 comments · Fixed by #829 or #835
Closed

C++ comment style and commented out code violations #828

zanzaben opened this issue Feb 23, 2021 · 0 comments · Fixed by #829 or #835
Assignees
@zanzaben
Labels
enhancement
Milestone
Caelum

Comments

@zanzaben
Copy link
Contributor

Is your feature request related to a problem? Please describe.
C++ comment style and commented out code violates style guidelines

osal/src/tests/select-test/select-test.c

Line 266 in ff4f523

// Server 1 is intentionaly left waiting so we close it out here.

Describe the solution you'd like
Clean up

Describe alternatives you've considered
None

Requester Info
Alex Campbell GSFC
@zanzaben zanzaben self-assigned this Feb 23, 2021
zanzaben added a commit to zanzaben/osal that referenced this issue Feb 23, 2021
@zanzaben
Fix nasa#828, fix comment style
bbce4be
@zanzaben zanzaben mentioned this issue Feb 23, 2021
Merged
astrogeco added a commit that referenced this issue Mar 1, 2021
@astrogeco
Merge pull request #829 from zanzaben/fix828_fix_comment_style
f5b47d1 
Fix #828, fix comment style
@astrogeco astrogeco mentioned this issue Mar 1, 2021
Merged
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Fix nasa#828, Spacecraft ID sample set to historical value (0x42)
1be664e
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#829 from skliper/fix828-spacecraft-id-hex
965b11d 
Fix nasa#828, Spacecraft ID sample set to historical value (0x42)
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#860 from skliper/fix828-spacecraft-id-hex
0bca6dc 
Fix nasa#828, Spacecraft ID sample set to historical value (0x42)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanzaben zanzaben

Labels
enhancement
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Fix #828, fix comment style zanzaben/osal
osal Integration candidate: 2021-03-02 nasa/osal
2 participants
@zanzaben @skliper