Fix #1153, Remove logic based on LogEnabled status #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
the
CCB:Ready
astrogeco
added
CCB:2021-02-24
and removed
CCB:Ready
|
CCB:2021-02-24 APPROVED
|
skliper
force-pushed
the
fix1153-logenabled_logic
branch
from
219a615
to
ab4f3fc
Compare
skliper
force-pushed
the
fix1153-logenabled_logic
branch
from
ab4f3fc
to
693cb5d
Compare
|
@astrogeco - ready to merge |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Mar 4, 2021
Combines: - nasa/cFE#1196 - nasa/osal#835 - nasa/elf2cfetbl#72 Includes: - nasa/cFE#1154 - nasa/cFE#935 - nasa/cFE#1179 - nasa/cFE#1140 - nasa/cFE#1178 - nasa/cFE#1197 - nasa/osal#834 - nasa/osal#826 - nasa/osal#827 - nasa/osal#829 - nasa/osal#824 - nasa/elf2cfetbl#71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #1153 - no longer utilizing the LogEnabled element in HK telemetry for EVS logic, log is always enabled in this implementation
Testing performed
Built and executed unit tests, passed
Expected behavior changes
No real change, but on failures (reset area or semaphore) will panic.
System(s) tested on
Additional context
Confirmed still getting 100% line coverage
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC