Incorrect ReturnCode check in CFE_ES_CreateObjects

[jphickey]

Is your feature request related to a problem? Please describe.
The CFE_ES_StartAppTask returns a CFE status. However, when checking the the return code, it is compared to OS_SUCCESS, rather than CFE_SUCCESS.

cFE/modules/es/fsw/src/cfe_es_start.c

Lines 786 to 799 in 2afdbc1

	ReturnCode = CFE_ES_StartAppTask(
	&AppRecPtr->MainTaskId, AppRecPtr->AppName, CFE_ES_ObjectTable[i].FuncPtrUnion.MainTaskPtr,
	&AppRecPtr->StartParams.MainTaskInfo, CFE_ES_APPID_C(PendingAppId));
	/*
	* Finalize data in the app table entry, which must be done under lock.
	* This transitions the entry from being RESERVED to the real type,
	* either MAIN_TASK (success) or returning to INVALID (failure).
	*/
	CFE_ES_LockSharedData(__func__, __LINE__);
	if (ReturnCode == OS_SUCCESS)
	{
	CFE_ES_AppRecordSetUsed(AppRecPtr, PendingAppId);

Describe the solution you'd like
Check against CFE_SUCCESS

Describe alternatives you've considered
N/A

Additional context
This is just a minor/pedantic correctness issue, since in practice OS_SUCCESS and CFE_SUCCESS are the same value (0). However when scrubbing for type correctness this shows up.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

[jphickey]

Calling this an "enhancement" since they are the same value and type in practice (so not really "broken" in behavior), but should be fixed in the interest of correctness.

[jphickey]

I actually noticed a couple more cases of similar status code mismatch in other functions. I can submit a second PR to address them.

Should probably NOT close this issue with the current IC, though.