Fix #1698, correct return code check #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return code of CFE_ES_StartAppTask is a CFE status code, so it should be compared to CFE_SUCCESS, not OS_SUCCESS.
jphickey
added
the
CCB:Ready
astrogeco
added
CCB:Approved
|
CCB:2021-07-21 APPROVED
|
This was referenced Jul 21, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 22, 2021
nasa/cFE#1699, correct return code check nasa/cFE#1700, documentation for FS APIs that return OSAL codes nasa/cFE#1695, Adding coverage tests for cfe_es_apps.c
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 29, 2021
Combines: nasa/cFE#1701, v6.8.0-rc1+dev789 nasa/osal#1116, v5.1.0-rc1+dev578 nasa/cFS-GroundSystem#192, v2.2.0-rc1+dev58 Includes: **cFE** nasa/cFE#1699, correct return code check nasa/cFE#1700, documentation for FS APIs that return OSAL codes nasa/cFE#1695, Adding coverage tests for cfe_es_apps.c nasa/cFE#1673, Add File Utility Functional Tests. nasa/cFE#1711, Add custom epoch support to TIME UT nasa/cFE#1720, Requirements update for Caelum nasa/cFE#1721, Add null check to CFE_ES_TaskID_ToIndex. nasa/cFE#1719, scrub command documentation nasa/cFE#1715, Add time arithmetic functional tests nasa/cFE#1704, update docs for CFE_FS_BackgroundFileDumpRequest nasa/cFE#1706, correct return code mismatches **osal** nasa/osal#1114, Add unit test branch coverage **cFS-GroundSystem** nasa/cFS-GroundSystem#185, Update tlm for ES Blockstats/memstats and TBL HK nasa/cFS-GroundSystem#188, * might be referenced before assignment Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Alex Campbell <zanzaben@users.noreply.github.com> Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com> Co-authored-by: Niall Mullane <nmullane@users.noreply.github.com> Co-authored-by: Paul <pavll@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
The return code of CFE_ES_StartAppTask is a CFE status code, so it should be compared to CFE_SUCCESS, not OS_SUCCESS.
Fixes #1698
Testing performed
Build and sanity check CFE, run all tests
Expected behavior changes
None
System(s) tested on
Ubuntu
Additional context
No change to actual behavior here, this is just for type/symbol correctness
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.