Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code coverage workflow minimums are out-of-date #2442

Closed
2 tasks done
thnkslprpt opened this issue Sep 22, 2023 · 0 comments
Closed
2 tasks done

Code coverage workflow minimums are out-of-date #2442

thnkslprpt opened this issue Sep 22, 2023 · 0 comments

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Thanks to a reminder from Jake (@skliper) I thought it would be worth checking cFE for the same issue.

Apparently the minimum coverage barriers went out-of-date in cFE as well at some point. The main branch currently misses 51 branches (rather than 52) and 17 lines (rather than 18).

Code snips

Screenshot 2023-09-22 15 01 25

Expected behavior
These should be corrected - otherwise there may be no warning if a PR reduces coverage.

Reporter Info
Avi Weiss   @thnkslprpt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2442, Update code coverage mimimums thnkslprpt/cFE
1 participant
@thnkslprpt