Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce keeping coverage minimums up-to-date in Code Coverage CI workflow #1417

Closed
thnkslprpt opened this issue Sep 23, 2023 · 0 comments · Fixed by #1419
Closed

Enforce keeping coverage minimums up-to-date in Code Coverage CI workflow #1417

thnkslprpt opened this issue Sep 23, 2023 · 0 comments · Fixed by #1419

Comments

@thnkslprpt
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Code coverage minimums seem to go out-of-date quite often.
When these values aren't updated, the code coverage workflow will pass and it's likely that no alert will occur if a new PR reduces test coverage.

Describe the solution you'd like
Fail the code coverage workflow if a PR improves coverage but hasn't updated (lowered) the missed functions/lines/branches variables in the workflow file.

Describe alternatives you've considered
Leave as-is and check periodically that these minimum coverage variables are still up-to-date.

Requester Info
Avi Weiss   @thnkslprpt

thnkslprpt added a commit to thnkslprpt/osal that referenced this issue Sep 23, 2023
thnkslprpt added a commit to thnkslprpt/osal that referenced this issue Mar 23, 2024
thnkslprpt added a commit to thnkslprpt/osal that referenced this issue Aug 8, 2024
dzbaker added a commit that referenced this issue Aug 16, 2024
…orkflow-bug-fix-and-enforce-updating

Fix #1417, Fix #1418, Fix workflow bug and enforce updating of coverage minimums
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant