Subtle bug in Code Coverage CI workflow

[thnkslprpt]

Checklist

• I reviewed the Contributing Guide.
• I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
It seems that the intent of the standalone-build.yml workflow is to only run the 'Enforce coverage minimum' steps in the debug-ubuntu-20.04 build (there is a separate check for the release builds - osal_apicheck). However, I think they are currently running in all builds (incl. the 2 release builds in the matrix).

Therefore, they are referencing non-existent variables, because in the release and debug-ubuntu-22.04 builds the ncov_lines/functions/branches variables are never created.

The reason the checks normally 'pass' silently in those 3 builds is because they are comparing a non-existent variable (which they seem to treat as zero?) as greater than the env.allowed_ncov_functions/lines/branches variables (which will always evaluate to false as they obviously cannot be negative).

If you change any/all of the allowed_ncov_lines/branches/functions variables to -1, suddenly all 4 builds will fail (but the non-existent ncov_lines/functions/branches variables will not be able to be printed in 3/4 of the builds. This shows that these steps are running in all builds, whether intentionally or not:

They do print correctly (see inside the brackets at the end of the error strings) with the debug-20.04 build though. As mentioned, this is the only build in which the coverage data is actually created:

osal/.github/workflows/standalone-build.yml

Lines 36 to 38 in b5dd01c

	- name: Install Coverage Analysis Tools
	if: ${{ matrix.build-type == 'Debug' && matrix.base-os == 'ubuntu-20.04' }}
	run: sudo apt-get install -y lcov xsltproc && echo "run_lcov=TRUE" >> $GITHUB_ENV

osal/.github/workflows/standalone-build.yml

Lines 84 to 89 in b5dd01c

	- name: Check Coverage
	id: stats
	if: ${{ env.run_lcov == 'TRUE' }}
	uses: ./source/.github/actions/check-coverage
	with:
	binary-dir: build

Code snips
Here are the coverage checks:

osal/.github/workflows/standalone-build.yml

Lines 91 to 107 in b5dd01c

	- name: Enforce coverage function minimum
	if: ${{ always() && steps.stats.outputs.ncov_functions > env.allowed_ncov_functions }}
	run: |
	echo "::error::Too many uncovered functions (${{ steps.stats.outputs.ncov_functions }})"
	/bin/false
	- name: Enforce coverage line minimum
	if: ${{ always() && steps.stats.outputs.ncov_lines > env.allowed_ncov_lines }}
	run: |
	echo "::error::Too many uncovered lines (${{ steps.stats.outputs.ncov_lines }})"
	/bin/false
	- name: Enforce coverage branch minimum
	if: ${{ always() && steps.stats.outputs.ncov_branches > env.allowed_ncov_branches }}
	run: |
	echo "::error::Too many uncovered branches (${{ steps.stats.outputs.ncov_branches }})"
	/bin/false

Expected behavior
The coverage checks in the code snippet above should be set to run only on the debug builds (no reason not to add them in for ubuntu-22.04 as well, from what I can see), and not run on the release builds.

Reporter Info
Avi Weiss   @thnkslprpt