Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_config_includefile should display an error if no files are found at all #774

Closed
jphickey opened this issue Jul 9, 2020 · 1 comment · Fixed by #775 or #765
Closed

generate_config_includefile should display an error if no files are found at all #774

jphickey opened this issue Jul 9, 2020 · 1 comment · Fixed by #775 or #765
Assignees
Labels
Milestone

Comments

@jphickey
Copy link
Contributor

jphickey commented Jul 9, 2020

Is your feature request related to a problem? Please describe.
While testing other items I noticed that the generate_config_includefile function will happily create an empty file if neither a user-provided file nor a default/fallback file is available.

But because the file is present but doesn't have any actual content, you end up with a slightly obfuscated compiler error about missing symbols rather than an indication that the expected config file is empty.

Describe the solution you'd like
The function should trigger an error and inform the user that there was no file to use, rather than generating an empty file. It is a misconfiguration, so it should be corrected.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Jul 9, 2020
@jphickey
Copy link
Contributor Author

jphickey commented Jul 9, 2020

Calling it an "enhancement" as it isn't strictly broken - more of a reporting/informational concern. Could be argued to be a bug though, as the build should inform the user if their config is broken.

jphickey added a commit to jphickey/cFE that referenced this issue Jul 9, 2020
Report an error if no files are available to fulfill an
include file requirement, rather than leaving an empty file.
astrogeco added a commit that referenced this issue Jul 15, 2020
astrogeco pushed a commit that referenced this issue Jul 26, 2020
Report an error if no files are available to fulfill an
include file requirement, rather than leaving an empty file.
@astrogeco astrogeco added bug and removed enhancement labels Sep 15, 2020
@skliper skliper added this to the 6.8.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants