Fix #774, do not generate empty include file #775
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Detect the condition where no files were present to fulfill an config include file requirement, and report as an error rather than generating an empty file.
Fixes #774
Testing performed
Create a test config that refers to a nonexistent platform config called "foobar" by setting this in
targets.cmake
:SET(TGT1_PLATFORM foobar)
Without this change,
make prep
still (seemingly) completes successfully but thecfe_platform_cfg.h
is actually empty, which results in a later compiler error.Expected behavior changes
After applying this change, the issue is reported as a
make prep
error instead, along with a list of files it checked for.Example:
No FSW changes - just reporting this configuration error.
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.