Fix #1051, use OSAL time conversion/access methods #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of accessing OS_time_t values directly, use the OSAL-provided conversion and access methods. This provides independence/abstraction from the specific OS_time_t definition and allows OSAL to transition to a 64 bit value.
jphickey
added
the
CCB:Ready
astrogeco
added
CCB-20210106
dependency
and removed
CCB:Ready
|
CCB 2021-01-06 APPROVED
Needs nasa/osal#723 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Instead of accessing
OS_time_tvalues directly, use the OSAL-provided conversion and access methods. This providesindependence/abstraction from the specific `OS_time_t definition and allows OSAL to transition to a 64 bit value.
Fixes #1051
Testing performed
Build and run unit tests, sanity check CFE
Expected behavior changes
None (but see notes)
System(s) tested on
Ubuntu 20.04 (native)
RTEMS 4.11 + pc686 (qemu)
Additional context
By using the OSAL implementation of subsecond/microsecond conversion, this will correct some minor inaccuracies in the CFE TIME conversions that were never noticed before.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.