cFE Integration candidate: 2021-01-12 #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use OS_FileSysStatVolume() instead. This also enables the check to be more appropriate as this call reports the number of total blocks, not just the free blocks, so no workaround for desktop machines is needed.
Instead of accessing OS_time_t values directly, use the OSAL-provided conversion and access methods. This provides independence/abstraction from the specific OS_time_t definition and allows OSAL to transition to a 64 bit value.
Fix #260, Remove unused network_includes.h
Fix #1062, Remove CFE_SB_TimeOut_t typedef
Fix #1049, replace OS_fsBlocksFree
Fix #1051, use OSAL time conversion/access methods
Fix #1081, Correct deprecation directive typo
Update ReadMe
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #1049, replace OS_fsBlocksFree
Fix #1051, use OSAL time conversion/access methods
Fix #1062, remove CFE_SB_TimeOut_t typedef
Fix #260, Remove unused network_includes.h
Fix #1081, Correct deprecation directive typo
Testing performed
See https://github.com/nasa/cFS/pull/174/checks
Expected behavior changes
PR #1050 - Replace
OS_FileSysStatVolume()withOS_fsBlocksFree()which will be deprecated. This call reports the number of total blocks, not just the free blocks, making the check more accurate and removing the need for a workaround for desktop machines.PR #1058 - Instead of accessing
OS_time_tvalues directly, use the OSAL-provided conversion and access methods. This provides independence and abstraction from the specificOS_time_tdefinition and allows OSAL to transition to a 64 bit value.PR #1063 - Removes the spurious
CFE_SB_TimeOut_ttypedef fromcfe_sb.h. May affect any apps that inappropriately rely on the private typedef.PR #1067 - Removes unused
network_includes.h. Not used by the framework anywhere, apps should use OSAL Socket APIs instead.PR #1082 - Fixes deprecation directive typos
System(s) tested on
Ubuntu 18.04
Additional context
Part of nasa/cFS#174
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@skliper
@jphickey
@CDKnightNASA