Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1298, add Current Time Functional Test #1415

Conversation

zanzaben
Copy link
Contributor

Describe the contribution
Fixes #1298
adds new functional tests for Time Current API.

System(s) tested on
Ubuntu 20.04

Additional context
This is a just testing the nominal cases. More in depth tests will have to be added later.

Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

@zanzaben zanzaben added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Apr 22, 2021
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Apr 28, 2021
@astrogeco
Copy link
Contributor

astrogeco commented Apr 28, 2021

CCB:2021-04-27 APPROVED with CHANGES

  • Race condition with the equality comparision?
  • Shouldn't all of these test have a "slop factor" of sorts
  • Use osal function to get difference between two times and check the difference in the nano or subseconds

Copy link
Contributor

@astrogeco astrogeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See ccb comment

@zanzaben zanzaben force-pushed the Fix1298_Time_Current_Time_Functional_Test branch 2 times, most recently from 5070f94 to 240499f Compare May 3, 2021 16:09
@zanzaben zanzaben requested a review from jphickey May 3, 2021 16:10
@zanzaben
Copy link
Contributor Author

zanzaben commented May 3, 2021

Fixed issue of slop factor.

@astrogeco astrogeco changed the base branch from main to integration-candidate May 4, 2021 00:15
@astrogeco
Copy link
Contributor

@zanzaben looks like the conflicts you mentioned are here!

@zanzaben zanzaben force-pushed the Fix1298_Time_Current_Time_Functional_Test branch from 240499f to f8afaba Compare May 4, 2021 14:02
@zanzaben zanzaben removed the conflicts label May 4, 2021
@astrogeco astrogeco merged commit 911865c into nasa:integration-candidate May 4, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request May 5, 2021
nasa/cFE#1418, add ES CDS Functional test
nasa/cFE#1429, Function comment blocks
nasa/cFE#1414, Add Header Functional tests.
nasa/cFE#1415, add Current Time Functional Test
astrogeco added a commit to nasa/cFS that referenced this pull request May 5, 2021
cfe v6.8.0-rc1+dev559 and osal v5.1.0-rc1+dev417

Combines:

nasa/osal#979
nasa/cFE#1481

Includes:

nasa/osal#973, UtPrintx function
nasa/osal#976, add socket shutdown implementation

nasa/cFE#1418, add ES CDS Functional test
nasa/cFE#1429, Function comment blocks
nasa/cFE#1414, Add Header Functional tests.
nasa/cFE#1415, add Current Time Functional Test
@zanzaben zanzaben deleted the Fix1298_Time_Current_Time_Functional_Test branch May 21, 2021 16:16
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cFE Time Current Time API functional tests
3 participants