Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #810, add ES CDS Functional test #1418

Merged

Conversation

zanzaben
Copy link
Contributor

Describe the contribution
Fixes #810
adds new functional tests for es cds

System(s) tested on
Ubuntu 20.04

Additional context
This is a just testing the nominal cases. More in depth tests will have to be added later.

Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

@zanzaben zanzaben added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Apr 23, 2021
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Apr 28, 2021
@astrogeco
Copy link
Contributor

CCB:2021-04-28 APPROVED with CHANGES

  • Simple "success" cases
  • Only a starting point. More tests coming
  • Does not exercise the "rebuild" case. Need to do both
  • Need to let operator know what half of this is being tested
  • We have a command that does "delete CDS" do we want to put this in the public API?

Copy link
Contributor

@astrogeco astrogeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like there were some changes wanted in the CCB. Resolve if I missed anything

@zanzaben zanzaben force-pushed the fix810_ES_CDS_Functional_Test branch from cc74f7b to 8f77718 Compare April 28, 2021 16:47
@zanzaben
Copy link
Contributor Author

Changes have been made

@zanzaben zanzaben force-pushed the fix810_ES_CDS_Functional_Test branch from 8f77718 to 2c75f86 Compare April 29, 2021 14:05
@zanzaben zanzaben mentioned this pull request May 3, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate May 4, 2021 00:10
@astrogeco astrogeco merged commit 25926e4 into nasa:integration-candidate May 4, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request May 5, 2021
nasa/cFE#1418, add ES CDS Functional test
nasa/cFE#1429, Function comment blocks
nasa/cFE#1414, Add Header Functional tests.
nasa/cFE#1415, add Current Time Functional Test
astrogeco added a commit to nasa/cFS that referenced this pull request May 5, 2021
cfe v6.8.0-rc1+dev559 and osal v5.1.0-rc1+dev417

Combines:

nasa/osal#979
nasa/cFE#1481

Includes:

nasa/osal#973, UtPrintx function
nasa/osal#976, add socket shutdown implementation

nasa/cFE#1418, add ES CDS Functional test
nasa/cFE#1429, Function comment blocks
nasa/cFE#1414, Add Header Functional tests.
nasa/cFE#1415, add Current Time Functional Test
@zanzaben zanzaben deleted the fix810_ES_CDS_Functional_Test branch May 21, 2021 16:15
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cFE ES Critical Data Store API functional tests
3 participants