Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1906, Enforce minimum code coverage #1938

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Sep 7, 2021

Describe the contribution

Added enforcement of minimum coverage to CI, currently set to numbers achieved once all coverage PR's are in (ES and SB pending)

Testing performed
See results on branch with ES/SB merges at: https://github.com/skliper/cFE/runs/3536944299?check_suite_focus=true (PASSED)

Expected behavior changes
Only impact is to fail the workflow if code is added without associated code coverage.

System(s) tested on
CI (also ran it locally for testing)

Additional context
The numbers can be adjusted if code is added that really can't be covered (although we should avoid this) and/or as we resolve open coverage issues (all are documented).

Needs #1936 and #1922 merged to pass.

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Sep 7, 2021
@skliper skliper added this to the 7.0.0 milestone Sep 7, 2021
.github/workflows/code-coverage.yml Outdated Show resolved Hide resolved
.github/workflows/code-coverage.yml Outdated Show resolved Hide resolved
@astrogeco astrogeco changed the base branch from main to integration-candidate September 7, 2021 21:52
@astrogeco astrogeco merged commit 3300b43 into nasa:integration-candidate Sep 7, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 7, 2021
@astrogeco astrogeco removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Sep 8, 2021
@astrogeco
Copy link
Contributor

CCB:2021-09-08 APPROVED

@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label Sep 8, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 10, 2021
**Combines**

nasa/cFE#1939, v6.8.0-rc1+dev994
nasa/osal#1145, v5.1.0-rc1+dev604
nasa/PSP#307, v1.5.0-rc1+dev124
nasa/sch_lab#87, v2.4.0-rc1+dev47

**Includes**

*cFE*

nasa/cFE#1903, Update directory diagrams in application developer guide

nasa/cFE#1922, SB code coverage improvements #1905, Improve SB coverage

nasa/cFE#1936, Improve ES code coverage

nasa/cFE#1938, Enforce minimum code coverage

nasa/cFE#1940, Update dev guide for MSG and SBR

nasa/cFE#1941, Support unimplemented features in MSG FT

*osal*

nasa/osal#1144, Regex update in coverage enforcement to match .0

nasa/osal#1142, Add typecast to memchr call

*psp*

nasa/PSP#307, check that module type is not invalid

nasa/PSP#306, do not override add_psp_module for coverage test

*sch_lab*

nasa/sch_lab#86, add CmdCode to sch_lab_table

nasa/sch_lab#88, Fix missing typedef

Co-authored-by: Jacob Hageman           <skliper@users.noreply.github.com>
Co-authored-by: Joseph Hickey           <jphickey@users.noreply.github.com>
Co-authored-by: Ariel Adams             <ArielSAdamsNASA@users.noreply.github.com>
Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com>
@skliper skliper deleted the fix1906-enforce_coverage branch October 22, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB continuous-integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce cFE code coverage minimum statistics
3 participants