-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1931 Support unimplemented features in MSG ft #1941
Fix #1931 Support unimplemented features in MSG ft #1941
Conversation
CFE_Assert_STATUS_STORE(CFE_SB_TransmitMsg(&CFE_FT_BigMsg.Hdr, true)); | ||
if (!CFE_Assert_STATUS_MAY_BE(CFE_SUCCESS)) | ||
{ | ||
CFE_Assert_STATUS_MUST_BE(CFE_SB_BAD_ARGUMENT); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skliper I had to do this because every MID is valid for them, but I'm not convinced this is the right way to handle that scenario and I can't think of a better way.
@astrogeco as long as others approve could we get this one in main soon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a side note, I may actually need that "CFE_MSG_GenerateChecksum" part for the EDS stuff I'm working on too. The checksum exists (of course) but its handled differently and there is no reason for an app to read the checksum directly, so better to return NOT_IMPLEMENTED from the MSG Api.
6311022
to
51c6398
Compare
**Combines** nasa/cFE#1939, v6.8.0-rc1+dev994 nasa/osal#1145, v5.1.0-rc1+dev604 nasa/PSP#307, v1.5.0-rc1+dev124 nasa/sch_lab#87, v2.4.0-rc1+dev47 **Includes** *cFE* nasa/cFE#1903, Update directory diagrams in application developer guide nasa/cFE#1922, SB code coverage improvements #1905, Improve SB coverage nasa/cFE#1936, Improve ES code coverage nasa/cFE#1938, Enforce minimum code coverage nasa/cFE#1940, Update dev guide for MSG and SBR nasa/cFE#1941, Support unimplemented features in MSG FT *osal* nasa/osal#1144, Regex update in coverage enforcement to match .0 nasa/osal#1142, Add typecast to memchr call *psp* nasa/PSP#307, check that module type is not invalid nasa/PSP#306, do not override add_psp_module for coverage test *sch_lab* nasa/sch_lab#86, add CmdCode to sch_lab_table nasa/sch_lab#88, Fix missing typedef Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com> Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com>
CCB:2021-09-15 APPROVED |
Describe the contribution
MSG Functional Tests won't pass on gateway cert repo that uses a custom MSG api. This PR makes the necessary changes to support unimplemented features in the custom API.
Testing performed
Steps taken to test the contribution:
Expected behavior changes
Verify that unimplemented features in MSG api don't result in failures
System(s) tested on
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Jose F Martinez Pedraza / NASA GSFC