Fix #2218, add -fno-common to arch build flags #2219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add -fno-common to arch_build_custom_native.cmake so the CI workflows will all build with this option. This is not the default in the version of gcc/binutils used in ubuntu 20.04 on which the workflows run.
skliper
approved these changes
Dec 2, 2022
dzbaker
approved these changes
Dec 6, 2022
dzbaker
added
the
CCB:Ready
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 6, 2022
*Combines:* osal v6.0.0-rc4+dev173 cFE v7.0.0-rc4+dev229 **Includes:** *cFS* - #622 - #625 - #626 - #582 *osal* - nasa/osal#1342 - nasa/osal#1341 - nasa/osal#1321 *cFE* - nasa/cFE#2215 - nasa/cFE#2219 - nasa/cFE#2217 - nasa/cFE#2222 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com> Co-authored by: Avi Weiss: <thnkslprpt@users.noreply.github.com>
This was referenced Dec 6, 2022
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 6, 2022
*Combines:* osal v6.0.0-rc4+dev173 cFE v7.0.0-rc4+dev229 **Includes:** *cFS* - #622 - #625 - #626 - #582 *osal* - nasa/osal#1342 - nasa/osal#1341 - nasa/osal#1321 *cFE* - nasa/cFE#2215 - nasa/cFE#2219 - nasa/cFE#2217 - nasa/cFE#2222 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com> Co-authored by: Avi Weiss: <thnkslprpt@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Add -fno-common to arch_build_custom_native.cmake so the CI workflows will all build with this option. This is not the default in the version of gcc/binutils used in ubuntu 20.04 on which the workflows run.
Fixes #2218
Testing performed
Build and run all tests
Expected behavior changes
Duplicate global symbol names will trigger errors, rather than being silently merged on some versions of the tools (consistent behavior).
System(s) tested on
Ubuntu 22.04 and 20.04 (workflows)
Additional context
no-common is the default in newer versions of the tools, but was not the default in the versions used in 20.04. The CFE/CFS builds should not require/rely on the use of a common section.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.