Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #581, Broken links in docs #582

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Fix #581, Broken links in docs #582

merged 1 commit into from
Dec 6, 2022

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Sep 23, 2022 •
edited
Loading

Checklist (Please check before submitting)

Describe the contribution
Fixes #581
Corrects a few broken links in the contributing guide.
Also cleaned up a few other links for consistency.

Testing performed
Tested the links - working now.

Expected behavior changes
Links will work.

System(s) tested on
Chrome browser.

Contributor Info - All information REQUIRED for consideration of pull request
@thnkslprpt

@thnkslprpt thnkslprpt changed the title Fix #581, Broken links in CONTRIBUTING.md Fix #581, Broken links in docs Sep 24, 2022
@thnkslprpt thnkslprpt closed this Sep 24, 2022
@thnkslprpt thnkslprpt deleted the fix-581-contributing.md-typos branch September 24, 2022 08:24
@thnkslprpt thnkslprpt restored the fix-581-contributing.md-typos branch September 24, 2022 08:25
@thnkslprpt thnkslprpt reopened this Sep 24, 2022
@chillfig chillfig added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Sep 29, 2022
@chillfig chillfig self-requested a review September 29, 2022 18:50
chillfig
chillfig requested changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@chillfig chillfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCH can also be added to line 171.

CONTRIBUTING.md Show resolved Hide resolved
@chillfig
Copy link
Contributor

Hi @thnkslprpt , thank you for the pull request. It looks good! Just some comments about SCH.

@thnkslprpt
Copy link
Contributor Author

Hi @thnkslprpt , thank you for the pull request. It looks good! Just some comments about SCH.

No worries mate.
That's added now.

chillfig
chillfig requested changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@chillfig chillfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to follow a commit message convention throughout all cFS. At least, we want to change the commit message: "Add SCH to list of apps". Would you please squash the commits? git rebase -i HEAD~3 from your local cFS repo, squash the latter 2 commits, reword the 1 commit to "Fix #581, Updates broken links in docs". I think this makes sense since most of this pr's work is in lieu with that message. What do you think?

@thnkslprpt
Copy link
Contributor Author

thnkslprpt commented Sep 30, 2022 •
edited
Loading

What do you think?

Yeah that makes sense Justin. Let me know if I've updated it successfully now.
Cheers

@chillfig chillfig added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Oct 3, 2022
dzbaker added a commit that referenced this pull request Dec 6, 2022
@dzbaker
IC: Caelum-rc4+dev31
884d7d3 
*Combines:*

osal v6.0.0-rc4+dev173
cFE v7.0.0-rc4+dev229

**Includes:**

*cFS*
- #622
- #625
- #626
- #582

*osal*
- nasa/osal#1342
- nasa/osal#1341
- nasa/osal#1321

*cFE*
- nasa/cFE#2215
- nasa/cFE#2219
- nasa/cFE#2217
- nasa/cFE#2222

Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com>
Co-authored by: Avi Weiss: <thnkslprpt@users.noreply.github.com>
@dzbaker dzbaker mentioned this pull request Dec 6, 2022
Merged
2 tasks
dzbaker added a commit that referenced this pull request Dec 6, 2022
@dzbaker
IC: Caelum-rc4+dev31
265001a 
*Combines:*

osal v6.0.0-rc4+dev173
cFE v7.0.0-rc4+dev229

**Includes:**

*cFS*
- #622
- #625
- #626
- #582

*osal*
- nasa/osal#1342
- nasa/osal#1341
- nasa/osal#1321

*cFE*
- nasa/cFE#2215
- nasa/cFE#2219
- nasa/cFE#2217
- nasa/cFE#2222

Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com>
Co-authored by: Avi Weiss: <thnkslprpt@users.noreply.github.com>
@dzbaker dzbaker merged commit 700c9c7 into nasa:main Dec 6, 2022
@thnkslprpt thnkslprpt deleted the fix-581-contributing.md-typos branch December 6, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chillfig chillfig chillfig approved these changes

Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken links in docs
3 participants
@thnkslprpt @chillfig @dzbaker